Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set Geist as default font #2953

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: set Geist as default font #2953

wants to merge 2 commits into from

Conversation

veu
Copy link
Contributor

@veu veu commented Dec 11, 2024

Purpose of PR

Add Geist as new default font to both the primary and monospace font stacks.

PR Checklist

  • I have read the relevant readme.md file(s)
  • All commits follow our Git commit message convention
  • Tests are added/updated/not required
  • Tests are passing
  • Storybook stories are added/updated/not required
  • Usage notes are added/updated/not required
  • Has been tested based on Contentful's browser support
  • Doesn't contain any sensitive information

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Dec 11, 2024 11:00am

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 02f6680

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@contentful/f36-tokens Minor
@contentful/f36-core Minor
@contentful/f36-accordion Minor
@contentful/f36-asset Minor
@contentful/f36-autocomplete Minor
@contentful/f36-badge Minor
@contentful/f36-button Minor
@contentful/f36-card Minor
@contentful/f36-collapse Minor
@contentful/f36-copybutton Minor
@contentful/f36-datetime Minor
@contentful/f36-datepicker Minor
@contentful/f36-drag-handle Minor
@contentful/f36-entity-list Minor
@contentful/f36-empty-state Minor
@contentful/f36-forms Minor
@contentful/f36-icon Minor
@contentful/f36-header Minor
@contentful/f36-list Minor
@contentful/f36-menu Minor
@contentful/f36-modal Minor
@contentful/f36-navbar Minor
@contentful/f36-note Minor
@contentful/f36-notification Minor
@contentful/f36-pagination Minor
@contentful/f36-pill Minor
@contentful/f36-popover Minor
@contentful/f36-skeleton Minor
@contentful/f36-spinner Minor
@contentful/f36-table Minor
@contentful/f36-tabs Minor
@contentful/f36-text-link Minor
@contentful/f36-tooltip Minor
@contentful/f36-typography Minor
@contentful/f36-components Minor
@contentful/f36-image Minor
@contentful/f36-avatar Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 112.21 KB (+0.02% 🔺) 2.3 s (+0.02% 🔺) 1.2 s (+1.17% 🔺) 3.5 s
Module 110.89 KB (+0.04% 🔺) 2.3 s (+0.04% 🔺) 1.6 s (+5.68% 🔺) 3.8 s

@veu veu marked this pull request as ready for review December 11, 2024 11:09
@veu veu requested review from damann and a team as code owners December 11, 2024 11:09
@@ -105,6 +115,7 @@ export const GlobalStyles = ({
font-family: ${tokens.fontStackPrimary};
font-size: ${tokens.fontSizeM};
line-height: ${tokens.lineHeightM};
font-synthesis-weight: none;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I learned about this property.

Copy link
Collaborator

@cf-remylenoir cf-remylenoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, tested in Firefox, Edge, Safari, and Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants