Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Icon weight type from Phosphor #2727

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Extract Icon weight type from Phosphor #2727

merged 2 commits into from
Apr 25, 2024

Conversation

denkristoffer
Copy link
Collaborator

Purpose of PR

Pick icon weight value directly from Phosphor icon type.

@denkristoffer denkristoffer requested review from damann and a team as code owners April 24, 2024 16:35
@denkristoffer denkristoffer requested review from mdmjg and removed request for a team April 24, 2024 16:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 0b2b915

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Apr 25, 2024 11:39am

@denkristoffer denkristoffer merged commit 59f246c into feat/icons-v5 Apr 25, 2024
2 of 4 checks passed
@denkristoffer denkristoffer deleted the chore/icon-phosphor-type branch April 25, 2024 11:45
denkristoffer added a commit that referenced this pull request Jun 28, 2024
@denkristoffer
Extract Icon weight type from Phosphor (#2727)
242a80f
cf-remylenoir pushed a commit that referenced this pull request Jul 17, 2024
@denkristoffer @cf-remylenoir
Extract Icon weight type from Phosphor (#2727)
5fa7e05
Lelith pushed a commit that referenced this pull request Aug 16, 2024
@denkristoffer @Lelith
Extract Icon weight type from Phosphor (#2727)
69522e9
This was referenced Aug 23, 2024
Merged
Merged
This was referenced Sep 12, 2024
Merged
Merged
Merged
Lelith pushed a commit that referenced this pull request Oct 23, 2024
@denkristoffer @Lelith
Extract Icon weight type from Phosphor (#2727)
9e83b23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damann damann Awaiting requested review from damann damann is a code owner

@mdmjg mdmjg Awaiting requested review from mdmjg mdmjg is a code owner automatically assigned from contentful/team-isotopes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@denkristoffer