Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(badge): restore default text transform #2731

Merged
merged 4 commits into from
Apr 26, 2024
Merged

Conversation

denkristoffer
Copy link
Collaborator

@denkristoffer denkristoffer commented Apr 25, 2024

Purpose of PR

Recent Badge change included a default CSS text-transform: capitalize, but this is not the same as the default we had, where only the first word was capitalized. This fixes that, but still allows users to avoid the transform overall. Also aligns with our existing styling APIs where we pass arguments to the individual style keys rather than the overall function.

@denkristoffer denkristoffer requested review from damann and a team as code owners April 25, 2024 11:33
Copy link

changeset-bot bot commented Apr 25, 2024

🦋 Changeset detected

Latest commit: 6d699b6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@contentful/f36-badge Patch
@contentful/f36-accordion Patch
@contentful/f36-asset Patch
@contentful/f36-autocomplete Patch
@contentful/f36-button Patch
@contentful/f36-card Patch
@contentful/f36-collapse Patch
@contentful/f36-copybutton Patch
@contentful/f36-core Patch
@contentful/f36-datetime Patch
@contentful/f36-datepicker Patch
@contentful/f36-drag-handle Patch
@contentful/f36-entity-list Patch
@contentful/f36-empty-state Patch
@contentful/f36-forms Patch
@contentful/f36-icon Patch
@contentful/f36-list Patch
@contentful/f36-menu Patch
@contentful/f36-modal Patch
@contentful/f36-note Patch
@contentful/f36-notification Patch
@contentful/f36-pagination Patch
@contentful/f36-pill Patch
@contentful/f36-popover Patch
@contentful/f36-skeleton Patch
@contentful/f36-spinner Patch
@contentful/f36-table Patch
@contentful/f36-tabs Patch
@contentful/f36-text-link Patch
@contentful/f36-tooltip Patch
@contentful/f36-typography Patch
@contentful/f36-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
forma-36 ✅ Ready (Inspect) Visit Preview Apr 26, 2024 7:08am

Copy link
Contributor

@stephanLeece stephanLeece left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link

github-actions bot commented Apr 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
CommonJS 132.89 KB (+0.02% 🔺) 2.7 s (+0.02% 🔺) 708 ms (+21.73% 🔺) 3.4 s
Module 129.59 KB (+0.03% 🔺) 2.6 s (+0.03% 🔺) 803 ms (+19.33% 🔺) 3.4 s

@denkristoffer denkristoffer enabled auto-merge (squash) April 26, 2024 07:06
@denkristoffer denkristoffer merged commit 91c71c0 into main Apr 26, 2024
12 checks passed
@denkristoffer denkristoffer deleted the fix/badge-style-default branch April 26, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants