Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LINT] Exclude directories from CT linting #187

Closed
Zethson opened this issue May 14, 2020 · 2 comments
Closed

[LINT] Exclude directories from CT linting #187

Zethson opened this issue May 14, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request low priority May or may not be worked on in the near future

Comments

@Zethson
Copy link
Member

Zethson commented May 14, 2020

ATM some functions check every file for something e.g. leftover cookiecutter statements.

It would be useful to state regexes/lists in the .cookietemple.cfg file, which exclude directories from being picked up by our custom linting functions.

@Zethson
Copy link
Member Author

Zethson commented May 14, 2020

Test Warnings: 
 https://cookietemple/linting/errors#3 : TODO string found in .travis.yml: uncomment if deploying with travis instead of Github CI
  https://cookietemple/linting/errors#3 : TODO string found in .travis.yml: uncomment if deploying with travis instead of Github CI
  https://cookietemple/linting/errors#3 : TODO string found in publish_package.yml: Configure your secrets to enable automatic deployme..
  https://cookietemple/linting/errors#3 : TODO string found in TemplateLinter.py: Go through all template files looking for the string ..
  https://cookietemple/linting/errors#3 : TODO string found in TemplateLinter.py: if 'TODO COOKIETEMPLE:' in line:
  https://cookietemple/linting/errors#3 : TODO string found in TemplateLinter.py: .replace('', '') \
  https://cookietemple/linting/errors#3 : TODO string found in TemplateLinter.py: .replace('', '') \
  https://cookietemple/linting/errors#3 : TODO string found in TemplateLinter.py: .replace('', '').strip()
  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_name }}

  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_short_descriptio..
  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_name }}

  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_short_descriptio..
  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_slug }}

  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_name }}

  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_short_descriptio..
  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_name }}

  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_short_descriptio..
  https://cookietemple/linting/errors#4 : Cookiecutter string found in 'README.rst': {{ cookiecutter.project_slug }}

@Zethson Zethson added the enhancement New feature or request label May 14, 2020
@Zethson Zethson changed the title [CORE] Exclude directories from CT linting [LINT] Exclude directories from CT linting Jun 17, 2020
@Zethson Zethson added the low priority May or may not be worked on in the near future label Jun 17, 2020
@Imipenem
Copy link
Collaborator

Imipenem commented Dec 5, 2020

Closing this in favor of #535

@Imipenem Imipenem closed this as completed Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority May or may not be worked on in the near future
Projects
None yet
Development

No branches or pull requests

2 participants