Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LINT] Improve efficiency of TemplateLinter #199

Closed
Imipenem opened this issue May 20, 2020 · 3 comments
Closed

[LINT] Improve efficiency of TemplateLinter #199

Imipenem opened this issue May 20, 2020 · 3 comments
Assignees
@Zethson @Imipenem
Labels
enhancement New feature or request low priority May or may not be worked on in the near future

Comments

@Imipenem
Copy link
Collaborator

Associated Template/Command/Core
Lint

Is your feature request related to a problem? Please describe.
Currently, when a template is linted, for every function that is called, a file is read again.

Describe the solution you'd like
We should completely refactor this, so that a read is at most called once per file.
@Imipenem Imipenem added the enhancement New feature or request label May 20, 2020
@Zethson Zethson changed the title Improve efficiency of TemplateLinter [CORE] Improve efficiency of TemplateLinter Jun 10, 2020
@Zethson Zethson added the low priority May or may not be worked on in the near future label Jun 12, 2020
@Zethson Zethson changed the title [CORE] Improve efficiency of TemplateLinter [LINT] Improve efficiency of TemplateLinter Jun 17, 2020
@Zethson
Copy link
Member

Zethson commented Aug 8, 2020

Could as a first step also try to parallelize all Conda (not yet in any template) and pip requests (latest version checks).

@Imipenem
Copy link
Collaborator Author

Imipenem commented Aug 9, 2020

Interesting yeah would be a cool learning experience at least

@Zethson Zethson added low priority May or may not be worked on in the near future and removed low priority May or may not be worked on in the near future labels Nov 8, 2020
@Imipenem
Copy link
Collaborator Author

Imipenem commented Dec 5, 2020

Closing in favor of #535

@Imipenem Imipenem closed this as completed Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zethson Zethson

@Imipenem Imipenem

Labels
enhancement New feature or request low priority May or may not be worked on in the near future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Zethson @Imipenem