Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom convertCurrency function #53

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

JB1905
Copy link
Member

@JB1905 JB1905 commented Jun 10, 2021

Closes #33
Closes #39

@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #53 (7ad11af) into master (f99c310) will decrease coverage by 3.33%.
The diff coverage is 96.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #53      +/-   ##
===========================================
- Coverage   100.00%   96.66%   -3.34%     
===========================================
  Files            3        3              
  Lines           33       30       -3     
  Branches         8        7       -1     
===========================================
- Hits            33       29       -4     
- Misses           0        1       +1     
Impacted Files Coverage Δ
src/useCurrency.ts 96.15% <96.00%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f99c310...7ad11af. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better tests with hook params change Add convertCurrency function
1 participant