Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Robust Error Checking to Library and Worker's Communication Patterns #3974

Merged
merged 9 commits into from
Nov 22, 2024

Conversation

tphung3
Copy link
Contributor

@tphung3 tphung3 commented Nov 6, 2024

Proposed Changes

This PR introduces more error checking in the worker when a library first starts up. A worker now sanity-checks a library's name, task_id, and exec_mode instead of just the library's name.

A new library protocol number is also added and should be incremented every time the library changes its communication pattern with the worker.

Issue: #3439.

Merge Checklist

The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.

  • make test Run local tests prior to pushing.
  • make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
  • make lint Run lint on source code prior to pushing.
  • Manual Update Update the manual to reflect user-visible changes.
  • Type Labels Select a github label for the type: bugfix, enhancement, etc.
  • Product Labels Select a github label for the product: TaskVine, Makeflow, etc.
  • PR RTM Mark your PR as ready to merge.

@tphung3 tphung3 changed the title WIP: Add Robust Error Checking to Library and Worker's Communications Add Robust Error Checking to Library and Worker's Communication Patterns Nov 7, 2024
@tphung3 tphung3 requested a review from dthain November 7, 2024 15:15
@tphung3 tphung3 requested a review from dthain November 11, 2024 20:27
taskvine/src/manager/vine_manager.c Outdated Show resolved Hide resolved
taskvine/src/manager/vine_protocol.h Outdated Show resolved Hide resolved
@tphung3 tphung3 requested a review from btovar November 21, 2024 15:17
@btovar
Copy link
Member

btovar commented Nov 21, 2024

ready to merge?

@tphung3
Copy link
Contributor Author

tphung3 commented Nov 21, 2024

Yep. It's RTM.

@btovar btovar merged commit 8530039 into cooperative-computing-lab:master Nov 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants