-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Robust Error Checking to Library and Worker's Communication Patterns #3974
Merged
btovar
merged 9 commits into
cooperative-computing-lab:master
from
tphung3:library-protocol
Nov 22, 2024
Merged
Add Robust Error Checking to Library and Worker's Communication Patterns #3974
btovar
merged 9 commits into
cooperative-computing-lab:master
from
tphung3:library-protocol
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tphung3
changed the title
WIP: Add Robust Error Checking to Library and Worker's Communications
Add Robust Error Checking to Library and Worker's Communication Patterns
Nov 7, 2024
dthain
requested changes
Nov 8, 2024
btovar
requested changes
Nov 18, 2024
btovar
approved these changes
Nov 21, 2024
ready to merge? |
Yep. It's RTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
This PR introduces more error checking in the worker when a library first starts up. A worker now sanity-checks a library's name, task_id, and exec_mode instead of just the library's name.
A new library protocol number is also added and should be incremented every time the library changes its communication pattern with the worker.
Issue: #3439.
Merge Checklist
The following items must be completed before PRs can be merge.
Check these off to verify you have completed all steps.
make test
Run local tests prior to pushing.make format
Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lint
Run lint on source code prior to pushing.