Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lock: short-circuit Manager.UnlockIfHeld if not holding a lock #9

Open
lucab opened this issue Apr 29, 2019 · 0 comments
Open

lock: short-circuit Manager.UnlockIfHeld if not holding a lock #9

lucab opened this issue Apr 29, 2019 · 0 comments

Comments

@lucab
Copy link
Contributor

lucab commented Apr 29, 2019

Capturing the discussion at https://github.com/coreos/airlock/pull/5/files#r279369060.

Manager.UnlockIfHeld can avoid a write-trip if the current id is not holding any semaphore lock. We should first augment Semaphore.UnlockIfHeld to signal back such situation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucab