Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to partition structure from #305 #331

Closed
dustymabe opened this issue Feb 7, 2019 · 6 comments
Closed

changes to partition structure from #305 #331

dustymabe opened this issue Feb 7, 2019 · 6 comments

Comments

@dustymabe
Copy link
Member

In #305 we switched to using reqpart --add-boot in our kickstart files.

This notably gives us an extra partition that we didn't have before and also gives us an ext4 formatted /boot partition. Before people start hardcoding in these assumptions (i.e. some early installer work POC assumes 1st partition is boot partition) we should strive to get closer to what we have laid out in the design document: https://github.com/coreos/fedora-coreos-tracker/blob/master/Design.md#summary-1

@dustymabe
Copy link
Member Author

cc @ajeddeloh since you have been looking at combined bios/uefi images since that might have some implications on our final partition layout.

@cgwalters
Copy link
Member

(i.e. some early installer work POC assumes 1st partition is boot partition)

Please find the filesystem with LABEL=boot instead.

@dustymabe
Copy link
Member Author

Please find the filesystem with LABEL=boot instead.

yeah I switched to that last night, need to add some extra logic in there just in case there is another disk attached to the system with a FS with that label, but it should work.

@ajeddeloh
Copy link
Contributor

Please label both the partitions and filesystems so they can be accessed as /dev/disk/by-partlabel/foo and /dev/disk/by-label/foo.

I don't know if we every consensus on the /boot and ESP split, but it's looking more like we'll need it. Basically we're going to need:

  1. /boot
  2. bios-boot
  3. ESP (probably to be mounted under /boot/efi or similar
  4. the rootfs
  5. (eventuall) /var

@dustymabe
Copy link
Member Author

I don't think anaconda sets partlabels. I only see the by-partuuid directory.

[root@coreos ~]# ls -d /dev/disk/by-part*
/dev/disk/by-partuuid

@dustymabe
Copy link
Member Author

This issue was mostly an FYI in case anyone noticed anything alarming that needed to be addressed. I'll close it out since there isn't really any work to be done and we can follow up on the partition structure in #334

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants