From 2bf8bbe627270dbe732b9b80cb8d97815d38d81c Mon Sep 17 00:00:00 2001 From: Jonathan Lebon Date: Mon, 6 Nov 2023 11:22:15 -0500 Subject: [PATCH] install: Don't require the network by default The `Wants=network-online.target` predates the osmet work which enabled the now default fully offline install flow. It also predates the addition of fetch retries. So even in an online flow, now that we retry HTTP requests indefinitely, we don't really need this. Let's follow best practices and stop pulling in `network-online.target`. We still need to keep pulling in `NetworkManager.service` though. It's enabled by default in `multi-user.target` but not `coreos-installer-post.target` (which is what we boot to in an automated install). NetworkManager is capable of handling offline environments just fine and won't block the install just because a connection isn't available (yet or ever). Related: https://github.com/coreos/fedora-coreos-config/pull/1088 Related: https://github.com/coreos/coreos-installer/pull/565#issuecomment-875709156 Related: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/ Closes: https://github.com/coreos/coreos-installer/issues/1334 --- docs/release-notes.md | 1 + systemd/coreos-installer.service | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/release-notes.md b/docs/release-notes.md index 7696a3f7d..cec0cd6bd 100644 --- a/docs/release-notes.md +++ b/docs/release-notes.md @@ -11,6 +11,7 @@ Major changes: Minor changes: +- install: Don't require the network by default Internal changes: diff --git a/systemd/coreos-installer.service b/systemd/coreos-installer.service index 3f507525f..f26f90949 100644 --- a/systemd/coreos-installer.service +++ b/systemd/coreos-installer.service @@ -1,8 +1,8 @@ [Unit] Description=CoreOS Installer Before=coreos-installer.target -After=network-online.target -Wants=network-online.target +After=NetworkManager.service +Wants=NetworkManager.service # Until we retry HTTP requests let's wait here until # systemd-resolved comes up if enabled. # https://github.com/coreos/coreos-installer/issues/283