Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package Request: audit #1362

Closed
c4rt0 opened this issue Dec 12, 2022 · 59 comments · Fixed by coreos/fedora-coreos-config#2590
Closed

New Package Request: audit #1362

c4rt0 opened this issue Dec 12, 2022 · 59 comments · Fixed by coreos/fedora-coreos-config#2590
Assignees
Labels

Comments

@c4rt0
Copy link
Member

c4rt0 commented Dec 12, 2022

What, if any, are the additional dependencies on the package? (i.e. does it pull in Python, Perl, etc)

[root@cosa-devsh ~]# rpm-ostree install --dry-run audit
...
Installing 2 packages:
  audit-3.0.9-1.fc37.x86_64 (fedora)
  initscripts-service-10.17-1.fc37.noarch (fedora)

What is the size of the package and its dependencies?

$ rpm -qi audit

Name        : audit
Version     : 3.0.9
Release     : 1.fc37
Architecture: x86_64
Install Date: Sat 05 Nov 2022 09:00:50
Group       : Unspecified
Size        : 684113
License     : GPLv2+
Signature   : RSA/SHA256, Tue 30 Aug 2022 00:18:08, Key ID f55ad3fb5323552a
Source RPM  : audit-3.0.9-1.fc37.src.rpm
Build Date  : Mon 29 Aug 2022 23:06:47
Build Host  : buildvm-x86-26.iad2.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : http://people.redhat.com/sgrubb/audit/
Bug URL     : https://bugz.fedoraproject.org/audit
Summary     : User space tools for kernel auditing
$  rpm -qi initscripts-service                                                                                                                                                                  1 err  11:39:35 
Name        : initscripts-service
Version     : 10.17
Release     : 1.fc37
Architecture: noarch
Install Date: Sat 05 Nov 2022 08:43:04
Group       : Unspecified
Size        : 5832
License     : GPLv2
Signature   : RSA/SHA256, Wed 24 Aug 2022 09:18:04, Key ID f55ad3fb5323552a
Source RPM  : initscripts-10.17-1.fc37.src.rpm
Build Date  : Wed 24 Aug 2022 09:13:16
Build Host  : buildvm-x86-14.iad2.fedoraproject.org
Packager    : Fedora Project
Vendor      : Fedora Project
URL         : https://github.com/fedora-sysv/initscripts
Bug URL     : https://bugz.fedoraproject.org/initscripts
Summary     : Support for service command

What problem are you trying to solve with this package? Or what functionality does the package provide?

The audit package contains the user space utilities for storing and searching the audit records generated by the audit subsystem in the Linux 2.6 and later kernels.

Can the software provided by the package be run from a container? Explain why or why not.

Yes, in theory, but it's likely not supported and will probably not work well with host filesystem rules.

Can the tool(s) provided by the package be helpful in debugging container runtime issues?

No

Can the tool(s) provided by the package be helpful in debugging networking issues?

No

Is it possible to layer the package onto the base OS as a day 2 operation? Explain why or why not.

Yes

In the case of packages providing services and binaries, can the packaging be adjusted to just deliver binaries?

TODO: Fill in bugs tracking that from previous issue

Can the tool(s) provided by the package be used to do things we’d rather users not be able to do in FCOS?

N/A

Does the software provided by the package have a history of CVEs?

No

?? https://www.cvedetails.com/product/13730/Linux-Audit.html?vendor_id=33

@travier
Copy link
Member

travier commented Dec 12, 2022

For the first question we need the output of Paste here the output of rpm-ostree install --dry-run <package> from a fresh Fedora CoreOS node. (see issue template text).

@travier
Copy link
Member

travier commented Dec 12, 2022

Same for the second question, check the issue template text

@travier travier added the jira for syncing to jira label Dec 12, 2022
@travier
Copy link
Member

travier commented Dec 12, 2022

See also #461

@c4rt0
Copy link
Member Author

c4rt0 commented Jan 26, 2023

Updated comment regarding rpm-ostree output in the first question.

@travier
Copy link
Member

travier commented Jan 27, 2023

For the second question, you should to give us the info for each package listed in the answer to the first question.

@travier
Copy link
Member

travier commented Jan 27, 2023

Next steps (can be done in parallel):

@c4rt0
Copy link
Member Author

c4rt0 commented Jan 27, 2023

Updated comment referring to size of the initscripts package

@travier
Copy link
Member

travier commented Jan 27, 2023

Hum, we need the info for the initscripts-service package, not the initscripts one 🙂.

@c4rt0
Copy link
Member Author

c4rt0 commented Jan 27, 2023

Of course - updated 😶‍🌫️

@jlebon
Copy link
Member

jlebon commented Jan 27, 2023

IMO, I don't think we should add initscripts-service to FCOS as is. It brings back /usr/sbin/service which is a legacy API. We discussed in the meeting maybe doing something in postprocessing as a last resort, but ideally we come to an agreement at the packaging level to e.g. lower it to a weak dep maybe and shipping auditd-{condrestart,reload,restart,resume,rotate,state,stop} scripts instead (those are the supported service actions that rely on direct signaling).

@travier
Copy link
Member

travier commented Jan 30, 2023

Looking at https://bugzilla.redhat.com/show_bug.cgi?id=1827263 and the auditd.service unit again (https://github.com/linux-audit/audit-userspace/blob/master/init.d/auditd.service), it's not clear to me that we should remove either auditctl or augenrules.

@travier
Copy link
Member

travier commented Jan 30, 2023

Context for service binary removal:

@travier
Copy link
Member

travier commented Jan 30, 2023

The audit package already includes the following scripts (https://github.com/linux-audit/audit-userspace/tree/master/init.d):

$ rpm -ql audit-3.0.9-1.fc37.x86_64 | grep legacy
/usr/libexec/initscripts/legacy-actions/auditd
/usr/libexec/initscripts/legacy-actions/auditd/condrestart
/usr/libexec/initscripts/legacy-actions/auditd/reload
/usr/libexec/initscripts/legacy-actions/auditd/restart
/usr/libexec/initscripts/legacy-actions/auditd/resume
/usr/libexec/initscripts/legacy-actions/auditd/rotate
/usr/libexec/initscripts/legacy-actions/auditd/state
/usr/libexec/initscripts/legacy-actions/auditd/stop

@travier
Copy link
Member

travier commented Jan 30, 2023

  • Option A: The short option is thus just to remove the service binary and man page in a post-script.
  • Option B: The long option is to rewrite those as a proper standalone script that is not correlated to the service binary.
  • Option C: Another option is to move the service binary somewhere else and include a wrapper script that only accepts auditd as an option for calls to service auditd <stop|restart|...> and rejects everything else.

@travier
Copy link
Member

travier commented Jan 30, 2023

Flagging for meeting discussion but I won't be here this week so maybe next week.

@c4rt0
Copy link
Member Author

c4rt0 commented Feb 14, 2023

Since I was on a course last week, I wonder if there were any debate related to this topic?

@travier
Copy link
Member

travier commented Feb 14, 2023

Not yet. There will likely be this week.

@travier
Copy link
Member

travier commented Feb 14, 2023

You can check the meeting logs (see the README in this repo) for each meeting.

@travier
Copy link
Member

travier commented Feb 15, 2023

@travier
Copy link
Member

travier commented Feb 15, 2023

@travier
Copy link
Member

travier commented Feb 15, 2023

We'll have to reach out to the audit maintainers to see which path they would prefer to ideally implement option B.

travier added a commit to travier/fedora-coreos-config that referenced this issue Sep 11, 2023
Include audit to be able to manage and load rules in the audit subsystem
in the kernel.

Fixes: coreos/fedora-coreos-tracker#1362
travier added a commit to travier/fedora-coreos-config that referenced this issue Sep 11, 2023
Include audit to be able to manage and load rules in the audit subsystem
in the kernel.

Fixes: coreos/fedora-coreos-tracker#1362
travier added a commit to travier/fedora-coreos-docs that referenced this issue Sep 11, 2023
dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this issue Sep 11, 2023
Include audit to be able to manage and load rules in the audit subsystem
in the kernel.

Fixes: coreos/fedora-coreos-tracker#1362
@dustymabe dustymabe added status/pending-next-release Fixed upstream. Waiting on a next release. F39 and removed status/decided labels Sep 12, 2023
@travier
Copy link
Member

travier commented Sep 12, 2023

Note for when we enable next-devel: we'll have to confirm that initscripts-service is not pulled-in.

jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Sep 12, 2023
We want to make sure we never unknowingly start shipping this package.
Relevant with the recent addition of audit which used to pull it in:

coreos/fedora-coreos-tracker#1362
@jlebon
Copy link
Member

jlebon commented Sep 12, 2023

Note for when we enable next-devel: we 'll have to confirm that initscripts-service is not pulled-in.

Opened coreos/fedora-coreos-config#2591 which will guarantee this. :)

dustymabe pushed a commit to coreos/fedora-coreos-config that referenced this issue Sep 12, 2023
We want to make sure we never unknowingly start shipping this package.
Relevant with the recent addition of audit which used to pull it in:

coreos/fedora-coreos-tracker#1362
travier added a commit to coreos/fedora-coreos-docs that referenced this issue Sep 20, 2023
@dustymabe
Copy link
Member

The fix for this went into next stream release 39.20230916.1.1. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-testing-release Fixed upstream. Waiting on a testing release. and removed status/pending-next-release Fixed upstream. Waiting on a next release. labels Sep 20, 2023
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Include audit to be able to manage and load rules in the audit subsystem
in the kernel.

Fixes: coreos/fedora-coreos-tracker#1362
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
We want to make sure we never unknowingly start shipping this package.
Relevant with the recent addition of audit which used to pull it in:

coreos/fedora-coreos-tracker#1362
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
Include audit to be able to manage and load rules in the audit subsystem
in the kernel.

Fixes: coreos/fedora-coreos-tracker#1362
HuijingHei pushed a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 10, 2023
We want to make sure we never unknowingly start shipping this package.
Relevant with the recent addition of audit which used to pull it in:

coreos/fedora-coreos-tracker#1362
@dustymabe
Copy link
Member

The fix for this went into testing stream release 39.20231101.2.0. Please try out the new release and report issues.

@dustymabe dustymabe added status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. and removed status/pending-testing-release Fixed upstream. Waiting on a testing release. labels Nov 7, 2023
@dustymabe
Copy link
Member

The fix for this went into stable stream release 39.20231101.3.0.

@dustymabe dustymabe removed the status/pending-stable-release Fixed upstream and in testing. Waiting on stable release. label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants