Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend bootupd test to include testing adoption and updates #1788

Closed
travier opened this issue Aug 28, 2024 · 5 comments
Closed

Extend bootupd test to include testing adoption and updates #1788

travier opened this issue Aug 28, 2024 · 5 comments

Comments

@travier
Copy link
Member

travier commented Aug 28, 2024

Describe the enhancement

Can probably borrow some idea from upstream tests.

System details

N/A

Additional information

Would have helped with:

@jlebon
Copy link
Member

jlebon commented Aug 28, 2024

And also strengthen the current bootupd test to sanity-check the output of bootupctl status:
https://github.com/coreos/fedora-coreos-config/blob/testing-devel/tests/kola/boot/bootupd

One easy way to sanity-check it is to look for the NEVRAs of the installed grub and shim packages in the output since in the context of this test, we're guaranteed to be running the same contentset the bootloader was installed from.

@HuijingHei
Copy link
Member

sanity-check the output of bootupctl status: coreos/fedora-coreos-config#3130

@travier
Copy link
Member Author

travier commented Sep 3, 2024

Another potential test would be to:

  • Overwrite an existing file in the ESP
  • Verify that bootupctl validate now fails
  • Remove /boot/bootupd-state.json
  • Adopt / update again
  • Verify that validate is successful

@HuijingHei
Copy link
Member

Hold this issue until we transfer to F41 which has new bootupd-0.2.24-1 (for coreos/fedora-coreos-config#3181).

HuijingHei added a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 18, 2024
HuijingHei added a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 18, 2024
HuijingHei added a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 21, 2024
HuijingHei added a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 23, 2024
HuijingHei added a commit to HuijingHei/fedora-coreos-config that referenced this issue Oct 25, 2024
jmarrero pushed a commit to coreos/fedora-coreos-config that referenced this issue Oct 28, 2024
@HuijingHei
Copy link
Member

Can I close this as test is merged (and remove denylist in coreos/fedora-coreos-config#3235)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants