-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Event log module support #26
Comments
Currently py-etherscan-api doesn't provide support for event logs, see: corpetty/py-etherscan-api#26
I agree, this would be great! I'll take a look at writing it in over the next week if you don't get around to making a PR. |
Yes I can work on it, pretty soon. I've a working version locally for a different project, see https://github.com/AndreMiras/EtherollApp/blob/v20180517/src/pyetheroll.py#L593 Do you mind if we tackle #20 a bit before growing the code base. I can also help with this. I would like to at least have some tox testing plus continuous integration like Travis. For the CI I usually build it within a Dockerfile so I can really isolate and specify the whole environment. But if you think it's too much I can go the old fashion way. The annoying thins is Travis is running old OS. With Docker you put the (Linux) OS you want. |
20 is closed. |
Great thanks! I'll tackle the little missing tasks first because I'm too busy for the big one. But I keep it for later :) |
py-etherscan-api does not currently provide event logs support. That would be a nice one to have. See API documentation here: https://etherscan.io/apis#logs
I can work on it and make a pull request if you guys are interested.
The text was updated successfully, but these errors were encountered: