Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_all_transactions leads to error in connect #34

Open
rickyktan opened this issue May 31, 2018 · 6 comments
Open

get_all_transactions leads to error in connect #34

rickyktan opened this issue May 31, 2018 · 6 comments

Comments

@rickyktan
Copy link

I have been trying to collect and plot all contributions that were sent to a crowdsale address (ZRX as example)

Sending a request using get_all_transactions function seems to be working (i.e. transactions are added and pages are being counted and added) until the Etherscan API returns the page with an empty response

{"status":"0","message":"No transactions found","result":[]}

This triggers an error in the connect function

@corpetty
Copy link
Owner

corpetty commented Jan 4, 2019

This will be fixed by #8 . I'll be working on this soon as I've picked this project up as part of another project I'm working on.

@MarcelBeining
Copy link

any updates on this? ran into the same problem. guess the solution is quite simple by changing line 92ff in accounts.py to something like

try: 
    req = self.connect()
except EmptyResponse:
    print(
                    "Total number of transactions: {}".format(len(trans_list)))
    self.page = ''
    return trans_list

@corpetty
Copy link
Owner

Was out of town on holiday. Will pick this back up this week.

@MarekPas
Copy link

Problem still not solved:
raise EmptyResponse(data.get('message', 'no message')) etherscan.client.EmptyResponse: <Err: No transactions found>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@MarcelBeining @corpetty @rickyktan @MarekPas and others