Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeeSettings logic contract could brick tokens #336

Open
malteish opened this issue Mar 14, 2024 · 1 comment
Open

FeeSettings logic contract could brick tokens #336

malteish opened this issue Mar 14, 2024 · 1 comment

Comments

@malteish
Copy link
Collaborator

Problem

During creation and fee settings changes, a token contract checks if the new fee settings contract implements the interfaces required. A fee settings logic contract will pass this test, but is controlled by 0x. This means a token could never migrate away from this contract again.

Mitigation

avoid accidentally proposing a fee settings logic contract to a token, e.g. by reading the fee settings owner in the web app and rejecting if it is 0x (or not the owner we expect).

Fix

Have the token enforce that the owner of the fee settings contract is not 0x.

@CJentzsch
Copy link
Collaborator

The fix is more of a mitigation, as the non-0x address could be an unused address as well, but I think the fix is good enough. We should put it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants