Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Both branches of if-then-else are identical in pkg/ruler/ruler_test.go #6287

Open
chavacava opened this issue Oct 25, 2024 · 3 comments
Open
Assignees
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. good first issue These are great first issues. If you are looking for a place to start, start here!

Comments

@chavacava
Copy link

Both branches of if-then-else are identical in

cortex/pkg/ruler/ruler_test.go

Lines 1073 to 1077 in 275a5bf

if tc.shardingStrategy == util.ShardingStrategyShuffle {
require.Equal(t, int32(tc.expectedClientCallCount), mockPoolClient.numberOfCalls.Load())
} else {
require.Equal(t, int32(tc.expectedClientCallCount), mockPoolClient.numberOfCalls.Load())
}

Found with revive

@dosubot dosubot bot added the component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. label Oct 25, 2024
@CharlieTLe CharlieTLe added the good first issue These are great first issues. If you are looking for a place to start, start here! label Oct 27, 2024
@rahulmansharamani14
Copy link

Hi @chavacava, Is there anyone working on this? If not, I'd like to give it a try.

@chavacava
Copy link
Author

Hi @rahulmansharamani14 , I don't know if there is someone already working on the issue. I just reported the issue.

@friedrichg
Copy link
Member

it's yours @rahulmansharamani14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/rules Bits & bobs todo with rules and alerts: the ruler, config service etc. good first issue These are great first issues. If you are looking for a place to start, start here!
Projects
None yet
Development

No branches or pull requests

4 participants