From 5d6ef8ad286974aad4ef6629c86631d8ff20078e Mon Sep 17 00:00:00 2001
From: Anmol <anmol1696@gmail.com>
Date: Thu, 3 Oct 2024 15:35:54 +0530
Subject: [PATCH 1/4] feature: update starship context to include timeout,
 update tests (#562)

* update starship context to include timeout, update tests

* add timeout to params

* fix lint
---
 clients/js/__output__/custom-pod-ports.yaml               | 1 +
 clients/js/packages/cli/src/utils.ts                      | 5 ++++-
 .../__tests__/__snapshots__/client.config.test.ts.snap    | 4 ++--
 .../__tests__/__snapshots__/client.ports.test.ts.snap     | 4 ++--
 .../client/__tests__/__snapshots__/client.test.ts.snap    | 4 ++--
 clients/js/packages/client/src/client.ts                  | 8 ++++++--
 6 files changed, 17 insertions(+), 9 deletions(-)

diff --git a/clients/js/__output__/custom-pod-ports.yaml b/clients/js/__output__/custom-pod-ports.yaml
index d26a75f6..1458b998 100644
--- a/clients/js/__output__/custom-pod-ports.yaml
+++ b/clients/js/__output__/custom-pod-ports.yaml
@@ -7,6 +7,7 @@ chains:
   defaultPorts:
     rpc: 26657
     grpc: 9090
+    grpc-web: 9091
     rest: 1317
     exposer: 8081
     faucet: 8000
diff --git a/clients/js/packages/cli/src/utils.ts b/clients/js/packages/cli/src/utils.ts
index a4ad2489..981c4f19 100644
--- a/clients/js/packages/cli/src/utils.ts
+++ b/clients/js/packages/cli/src/utils.ts
@@ -38,7 +38,8 @@ export const params: string[] = [
   'repo',
   'repoUrl',
   'chart',
-  'namespace'
+  'namespace',
+  'timeout',
 ];
 
 export const loadConfig = (argv: any): Config => {
@@ -89,6 +90,8 @@ Command-line Options:
                         Will overide config file settings for name.
   --version <ver>   Specify the version of the Helm chart, default: v0.2.6.
                         Will overide config file settings for version.
+  --timeout <time>  Specify the timeout for the Helm operations, default: 10m.
+                        Will overide config file settings for timeout.
 
 Examples:
   $ starship start --config ./config/two-chain.yaml
diff --git a/clients/js/packages/client/__tests__/__snapshots__/client.config.test.ts.snap b/clients/js/packages/client/__tests__/__snapshots__/client.config.test.ts.snap
index d5ee5415..5c8d17f9 100644
--- a/clients/js/packages/client/__tests__/__snapshots__/client.config.test.ts.snap
+++ b/clients/js/packages/client/__tests__/__snapshots__/client.config.test.ts.snap
@@ -11,7 +11,7 @@ helm repo update
 helm search repo starship/devnet --version v0.2.3
 Call: deploy()
 Log: Installing the helm chart. This is going to take a while.....
-helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3
+helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3 --timeout 10m
 Log: Run "starship get-pods" to check the status of the cluster
 Call: startPortForward()
 Log: Attempting to stop any existing port-forwards...
@@ -46,7 +46,7 @@ exports[`StarshipClient setup 2`] = `
 "helm repo add starship https://cosmology-tech.github.io/starship/
 helm repo update
 helm search repo starship/devnet --version v0.2.3
-helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3
+helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3 --timeout 10m
 ps -ef | grep -i 'kubectl port-forward' | grep -v 'grep' | awk '{print $2}'
 sleep 2
 kubectl port-forward pods/osmosis-1-genesis-0 26657:26657 > /dev/null 2>&1 &
diff --git a/clients/js/packages/client/__tests__/__snapshots__/client.ports.test.ts.snap b/clients/js/packages/client/__tests__/__snapshots__/client.ports.test.ts.snap
index aed92e67..fe3ed320 100644
--- a/clients/js/packages/client/__tests__/__snapshots__/client.ports.test.ts.snap
+++ b/clients/js/packages/client/__tests__/__snapshots__/client.ports.test.ts.snap
@@ -11,7 +11,7 @@ helm repo update
 helm search repo starship/devnet --version v0.2.3
 Call: deploy()
 Log: Installing the helm chart. This is going to take a while.....
-helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3
+helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3 --timeout 10m
 Log: Run "starship get-pods" to check the status of the cluster
 Call: startPortForward()
 Log: Attempting to stop any existing port-forwards...
@@ -44,7 +44,7 @@ exports[`StarshipClient setup 2`] = `
 "helm repo add starship https://cosmology-tech.github.io/starship/
 helm repo update
 helm search repo starship/devnet --version v0.2.3
-helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3
+helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3 --timeout 10m
 ps -ef | grep -i 'kubectl port-forward' | grep -v 'grep' | awk '{print $2}'
 sleep 2
 kubectl port-forward pods/osmosis-1-genesis-0 1317:6767676 > /dev/null 2>&1 &
diff --git a/clients/js/packages/client/__tests__/__snapshots__/client.test.ts.snap b/clients/js/packages/client/__tests__/__snapshots__/client.test.ts.snap
index 9e314eca..05e28283 100644
--- a/clients/js/packages/client/__tests__/__snapshots__/client.test.ts.snap
+++ b/clients/js/packages/client/__tests__/__snapshots__/client.test.ts.snap
@@ -9,7 +9,7 @@ helm repo update
 helm search repo starship/devnet --version v0.2.3
 Call: deploy()
 Log: Installing the helm chart. This is going to take a while.....
-helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3
+helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3 --timeout 10m
 Log: Run "starship get-pods" to check the status of the cluster
 Call: startPortForward()
 Log: Attempting to stop any existing port-forwards...
@@ -44,7 +44,7 @@ exports[`StarshipClient setup 2`] = `
 "helm repo add starship https://cosmology-tech.github.io/starship/
 helm repo update
 helm search repo starship/devnet --version v0.2.3
-helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3
+helm install -f ../../__fixtures__/config.yaml osmojs starship/devnet --version v0.2.3 --timeout 10m
 ps -ef | grep -i 'kubectl port-forward' | grep -v 'grep' | awk '{print $2}'
 sleep 2
 kubectl port-forward pods/osmosis-1-genesis-0 26657:26657 > /dev/null 2>&1 &
diff --git a/clients/js/packages/client/src/client.ts b/clients/js/packages/client/src/client.ts
index deeee4b8..3521543e 100644
--- a/clients/js/packages/client/src/client.ts
+++ b/clients/js/packages/client/src/client.ts
@@ -22,6 +22,7 @@ export interface StarshipContext {
   namespace?: string;
   verbose?: boolean;
   curdir?: string;
+  timeout?: string;
 }
 
 export const defaultStarshipContext: Partial<StarshipContext> = {
@@ -30,7 +31,8 @@ export const defaultStarshipContext: Partial<StarshipContext> = {
   repoUrl: 'https://cosmology-tech.github.io/starship/',
   chart: 'starship/devnet',
   namespace: '',
-  version: ''
+  version: '',
+  timeout: '10m'
 };
 
 export interface PodPorts {
@@ -47,7 +49,7 @@ export interface PodPorts {
 }
 
 const defaultName: string = 'starship';
-const defaultVersion: string = 'v0.2.13';
+const defaultVersion: string = 'v0.2.14';
 
 // TODO talk to Anmol about moving these into yaml, if not already possible?
 const defaultPorts: PodPorts = {
@@ -395,6 +397,8 @@ export class StarshipClient implements StarshipClientI {
       this.ctx.chart,
       '--version',
       this.config.version,
+      '--timeout',
+      this.ctx.timeout,
       ...this.getDeployArgs(),
       ...options
     ];

From 38e1f8527edaac2210b31596e974052164ca76c3 Mon Sep 17 00:00:00 2001
From: Anmol1696 <anmol1696@gmail.com>
Date: Thu, 3 Oct 2024 14:08:56 +0400
Subject: [PATCH 2/4] chore(release): publish

 - @starship-ci/cli@2.10.2
 - @starship-ci/client@2.9.2
---
 clients/js/packages/cli/CHANGELOG.md    | 4 ++++
 clients/js/packages/cli/package.json    | 4 ++--
 clients/js/packages/client/CHANGELOG.md | 4 ++++
 clients/js/packages/client/package.json | 2 +-
 4 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/clients/js/packages/cli/CHANGELOG.md b/clients/js/packages/cli/CHANGELOG.md
index a91cb1f2..6fd54828 100644
--- a/clients/js/packages/cli/CHANGELOG.md
+++ b/clients/js/packages/cli/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.10.2](https://github.com/cosmology-tech/starship/compare/@starship-ci/cli@2.10.1...@starship-ci/cli@2.10.2) (2024-10-03)
+
+**Note:** Version bump only for package @starship-ci/cli
+
 ## [2.10.1](https://github.com/cosmology-tech/starship/compare/@starship-ci/cli@2.10.0...@starship-ci/cli@2.10.1) (2024-09-17)
 
 **Note:** Version bump only for package @starship-ci/cli
diff --git a/clients/js/packages/cli/package.json b/clients/js/packages/cli/package.json
index d189b000..0034b9e6 100644
--- a/clients/js/packages/cli/package.json
+++ b/clients/js/packages/cli/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@starship-ci/cli",
-  "version": "2.10.1",
+  "version": "2.10.2",
   "author": "Dan Lynch <pyramation@gmail.com>",
   "description": "Starship CLI",
   "main": "index.js",
@@ -55,7 +55,7 @@
     "@types/js-yaml": "^4.0.9"
   },
   "dependencies": {
-    "@starship-ci/client": "^2.9.1",
+    "@starship-ci/client": "^2.9.2",
     "chalk": "^4.1.0",
     "deepmerge": "^4.3.1",
     "inquirerer": "^1.9.0",
diff --git a/clients/js/packages/client/CHANGELOG.md b/clients/js/packages/client/CHANGELOG.md
index ebb8d012..07eb7daf 100644
--- a/clients/js/packages/client/CHANGELOG.md
+++ b/clients/js/packages/client/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+## [2.9.2](https://github.com/cosmology-tech/starship/compare/@starship-ci/client@2.9.1...@starship-ci/client@2.9.2) (2024-10-03)
+
+**Note:** Version bump only for package @starship-ci/client
+
 ## [2.9.1](https://github.com/cosmology-tech/starship/compare/@starship-ci/client@2.9.0...@starship-ci/client@2.9.1) (2024-09-17)
 
 **Note:** Version bump only for package @starship-ci/client
diff --git a/clients/js/packages/client/package.json b/clients/js/packages/client/package.json
index 49d684f8..4c5a50da 100644
--- a/clients/js/packages/client/package.json
+++ b/clients/js/packages/client/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@starship-ci/client",
-  "version": "2.9.1",
+  "version": "2.9.2",
   "author": "Dan Lynch <pyramation@gmail.com>",
   "description": "Starship CI Client",
   "main": "index.js",

From cf703bfe6f0184d963cc1eda6fd964c3b7927dc8 Mon Sep 17 00:00:00 2001
From: Anmol1696 <anmol1696@gmail.com>
Date: Fri, 4 Oct 2024 21:27:29 +0400
Subject: [PATCH 3/4] format starship js client

---
 clients/js/packages/cli/src/utils.ts     |  2 +-
 clients/js/packages/client/src/client.ts | 93 +++++++++++++++++++++++-
 2 files changed, 93 insertions(+), 2 deletions(-)

diff --git a/clients/js/packages/cli/src/utils.ts b/clients/js/packages/cli/src/utils.ts
index 981c4f19..5d543bc2 100644
--- a/clients/js/packages/cli/src/utils.ts
+++ b/clients/js/packages/cli/src/utils.ts
@@ -39,7 +39,7 @@ export const params: string[] = [
   'repoUrl',
   'chart',
   'namespace',
-  'timeout',
+  'timeout'
 ];
 
 export const loadConfig = (argv: any): Config => {
diff --git a/clients/js/packages/client/src/client.ts b/clients/js/packages/client/src/client.ts
index 3521543e..f8a72155 100644
--- a/clients/js/packages/client/src/client.ts
+++ b/clients/js/packages/client/src/client.ts
@@ -511,12 +511,35 @@ export class StarshipClient implements StarshipClientI {
       { log: false, silent: true }
     ).trim();
 
-    const [phase, readyList, restartCountList, reason] = result.split(/\s+/);
+    // Ensure the output contains valid fields to split
+    const parts = result.split(/\s+/);
+    if (parts.length < 3) {
+      this.log(
+        chalk.red(`Unexpected pod status output for ${podName}: ${result}`)
+      );
+      return;
+    }
+
+    const [phase, readyList, restartCountList, reason] = parts;
+
+    // Validate readyList and restartCountList before applying split
+    if (!readyList || !restartCountList) {
+      this.log(
+        chalk.red(
+          `Invalid ready or restart count for pod ${podName}: ${result}`
+        )
+      );
+      return;
+    }
+
     const ready = readyList.split(',').every((state) => state === 'true');
     const restarts = restartCountList
       .split(',')
       .reduce((acc, count) => acc + parseInt(count, 10), 0);
 
+    // check for repeated image pull errors
+    this.checkImagePullFailures(podName);
+
     this.podStatuses.set(podName, {
       phase,
       ready,
@@ -572,6 +595,74 @@ export class StarshipClient implements StarshipClientI {
     });
   }
 
+  public checkImagePullFailures(podName: string): void {
+    // Fetch events from kubectl describe for the given pod
+    const eventLines = this.getPodEventsFromDescribe(podName);
+    const errorPattern = /Failed to pull image/;
+    const imageErrors: { [image: string]: number } = {};
+
+    // Parse through event lines to identify image pull failures
+    eventLines.forEach((line) => {
+      const message = line || '';
+      if (errorPattern.test(message)) {
+        const imageMatch = message.match(/image "(.*?)"/);
+        if (imageMatch && imageMatch[1]) {
+          const imageName = imageMatch[1];
+          imageErrors[imageName] = (imageErrors[imageName] || 0) + 1;
+        }
+      }
+    });
+
+    // Log errors for images that have failed more than twice
+    Object.entries(imageErrors).forEach(([imageName, errorCount]) => {
+      if (errorCount >= 3) {
+        this.log(
+          `${chalk.red(
+            `
+            Error: Image '${imageName}' failed to pull ${errorCount} times for pod ${podName}.
+            Please check the image name and ensure it is correct.
+            Run "starship stop" to stop the deployment which would be in stuck state.
+            `
+          )}`
+        );
+        this.exit(1);
+      }
+    });
+  }
+
+  private getPodEventsFromDescribe(podName: string): string[] {
+    // Execute the 'kubectl describe pod' command
+    const result = this.exec(
+      ['kubectl', 'describe', 'pod', podName, ...this.getArgs()],
+      { log: false, silent: true }
+    );
+
+    // Check if the command was successful
+    if (result.code !== 0) {
+      this.log(
+        chalk.red(`Failed to describe pod ${podName}: ${result.stderr}`)
+      );
+      return [];
+    }
+
+    const describeOutput = result.stdout;
+
+    // Extract the 'Events' section from the describe output
+    const eventsSection = describeOutput.split('Events:')[1];
+    if (!eventsSection) {
+      this.log(chalk.yellow(`No events found for pod ${podName}`));
+      return [];
+    }
+
+    // Split the events section into individual lines
+    const eventLines = eventsSection
+      .split('\n')
+      .filter((line) => line.trim() !== '');
+    this.log(`event lints: ${eventLines.join('\n')}`);
+
+    return eventLines;
+  }
+
   private forwardPort(
     chain: Chain,
     localPort: number,

From ec9d0ee51d87ca381b102964d9c479528da9319f Mon Sep 17 00:00:00 2001
From: Anmol <anmol1696@gmail.com>
Date: Mon, 7 Oct 2024 15:06:32 +0530
Subject: [PATCH 4/4] feature: expose readinessProbe to the config file for
 chain, add to doc, fix readinessProbe (#565)

* expose readinessProbe to the config file for chain, add to doc, fix readinessProbe

* add patch version release
---
 docs/pages/config/chains.mdx                  | 19 +++++++++++++++++++
 starship/charts/devnet/Chart.yaml             |  2 +-
 starship/charts/devnet/defaults.yaml          |  3 +++
 .../templates/chains/cosmos/genesis.yaml      |  2 +-
 .../templates/chains/cosmos/validator.yaml    |  2 +-
 starship/charts/devnet/values.schema.json     |  3 +++
 6 files changed, 28 insertions(+), 3 deletions(-)

diff --git a/docs/pages/config/chains.mdx b/docs/pages/config/chains.mdx
index ff17c549..526c0e7f 100644
--- a/docs/pages/config/chains.mdx
+++ b/docs/pages/config/chains.mdx
@@ -351,3 +351,22 @@ chains:
       coins: 100000000000000uion
 ```
 
+## `readinessProbe` (optional)
+The `readinessProbe` directive allows you to set the readiness probe for the chain pods. This is useful when you want to test a chain with specific readiness probe settings.
+Note, this is the same as the [kubernetes readiness probe](https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/)
+
+```yaml
+chains:
+- id: osmosis-1
+  name: osmosis
+  numValidators: 1
+  readinessProbe:
+    exec:
+      command:
+      - bash
+      - -c
+      - |
+        $CHAIN_BIN status 2>&1 | jq -e '.SyncInfo.catching_up == false'
+    initialDelaySeconds: 60
+    periodSeconds: 20
+```
diff --git a/starship/charts/devnet/Chart.yaml b/starship/charts/devnet/Chart.yaml
index 6e39cd8c..379f0bc5 100644
--- a/starship/charts/devnet/Chart.yaml
+++ b/starship/charts/devnet/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.14
+version: 0.2.15
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to
diff --git a/starship/charts/devnet/defaults.yaml b/starship/charts/devnet/defaults.yaml
index 83e7c49a..4383c353 100644
--- a/starship/charts/devnet/defaults.yaml
+++ b/starship/charts/devnet/defaults.yaml
@@ -689,6 +689,9 @@ defaultChains:
             trap 'kill $killer 2>/dev/null' EXIT
             # Return the test's exit code, whether it succeeded, failed, or was killed.
             wait $tester
+      initialDelaySeconds: 10
+      periodSeconds: 10
+      timeoutSeconds: 15
   kujira:
     image: ghcr.io/cosmology-tech/starship/kujira:v1.1.0
     home: /root/.kujira
diff --git a/starship/charts/devnet/templates/chains/cosmos/genesis.yaml b/starship/charts/devnet/templates/chains/cosmos/genesis.yaml
index f5da9e06..7748d34d 100644
--- a/starship/charts/devnet/templates/chains/cosmos/genesis.yaml
+++ b/starship/charts/devnet/templates/chains/cosmos/genesis.yaml
@@ -287,10 +287,10 @@ spec:
             httpGet:
               path: /status
               port: 26657
-            {{- end }}
             initialDelaySeconds: 10
             periodSeconds: 10
             timeoutSeconds: 15
+            {{- end }}
           {{- end }}
         - name: exposer
           image: {{ $.Values.exposer.image }}
diff --git a/starship/charts/devnet/templates/chains/cosmos/validator.yaml b/starship/charts/devnet/templates/chains/cosmos/validator.yaml
index fab591ee..3e9438e1 100644
--- a/starship/charts/devnet/templates/chains/cosmos/validator.yaml
+++ b/starship/charts/devnet/templates/chains/cosmos/validator.yaml
@@ -292,10 +292,10 @@ spec:
             httpGet:
               path: /status
               port: 26657
-            {{- end }}
             initialDelaySeconds: 10
             periodSeconds: 10
             timeoutSeconds: 15
+            {{- end }}
           {{- end }}
         - name: exposer
           image: {{ $.Values.exposer.image }}
diff --git a/starship/charts/devnet/values.schema.json b/starship/charts/devnet/values.schema.json
index 5549369d..5d2fe6fe 100644
--- a/starship/charts/devnet/values.schema.json
+++ b/starship/charts/devnet/values.schema.json
@@ -556,6 +556,9 @@
                 "amount"
               ]
             }
+          },
+          "readinessProbe": {
+            "type": "object"
           }
         },
         "additionalProperties": false,