From 4274dcf4429cc725a3bda58410bd8325d721a3e9 Mon Sep 17 00:00:00 2001
From: Hoa Nguyen <hoa@notional.ventures>
Date: Tue, 15 Oct 2024 04:25:11 +0700
Subject: [PATCH] refactor: add close body after use and fix lint (#22248)

---
 collections/quad.go                            |  1 +
 server/v2/cometbft/abci.go                     |  2 +-
 .../integration/tx/aminojson/aminojson_test.go | 18 ------------------
 tools/hubl/internal/registry.go                |  5 ++++-
 4 files changed, 6 insertions(+), 20 deletions(-)

diff --git a/collections/quad.go b/collections/quad.go
index 9d8d42a60644..cf17cc32eaba 100644
--- a/collections/quad.go
+++ b/collections/quad.go
@@ -241,6 +241,7 @@ func (t quadKeyCodec[K1, K2, K3, K4]) Encode(buffer []byte, key Quad[K1, K2, K3,
 	}
 	return writtenTotal, nil
 }
+
 func (t quadKeyCodec[K1, K2, K3, K4]) Decode(buffer []byte) (int, Quad[K1, K2, K3, K4], error) {
 	readTotal := 0
 	read, key1, err := t.keyCodec1.DecodeNonTerminal(buffer)
diff --git a/server/v2/cometbft/abci.go b/server/v2/cometbft/abci.go
index 75618e296022..f64ecb5b8c11 100644
--- a/server/v2/cometbft/abci.go
+++ b/server/v2/cometbft/abci.go
@@ -108,7 +108,7 @@ func NewConsensus[T transaction.Tx](
 		indexedEvents:          indexedEvents,
 		initialHeight:          0,
 		queryHandlersMap:       queryHandlersMap,
-		getProtoRegistry:       sync.OnceValues(func() (*protoregistry.Files, error) { return gogoproto.MergedRegistry() }),
+		getProtoRegistry:       sync.OnceValues(gogoproto.MergedRegistry),
 	}
 }
 
diff --git a/tests/integration/tx/aminojson/aminojson_test.go b/tests/integration/tx/aminojson/aminojson_test.go
index c68f24e97865..38aecaa9b30f 100644
--- a/tests/integration/tx/aminojson/aminojson_test.go
+++ b/tests/integration/tx/aminojson/aminojson_test.go
@@ -2,7 +2,6 @@ package aminojson
 
 import (
 	"bytes"
-	"encoding/json"
 	"fmt"
 	stdmath "math"
 	"testing"
@@ -454,20 +453,3 @@ func postFixPulsarMessage(msg proto.Message) {
 		}
 	}
 }
-
-// sortJson sorts the JSON bytes by way of the side effect of unmarshalling and remarshalling the JSON
-// using encoding/json.  This hacky way of sorting JSON fields was used by the legacy amino JSON encoding in
-// x/auth/migrations/legacytx.StdSignBytes.  It is used here ensure the x/tx JSON encoding is equivalent to
-// the legacy amino JSON encoding.
-func sortJson(bz []byte) ([]byte, error) {
-	var c any
-	err := json.Unmarshal(bz, &c)
-	if err != nil {
-		return nil, err
-	}
-	js, err := json.Marshal(c)
-	if err != nil {
-		return nil, err
-	}
-	return js, nil
-}
diff --git a/tools/hubl/internal/registry.go b/tools/hubl/internal/registry.go
index a3eea12391e4..945e0ff4296c 100644
--- a/tools/hubl/internal/registry.go
+++ b/tools/hubl/internal/registry.go
@@ -26,12 +26,15 @@ func GetChainRegistryEntry(chain string) (*ChainRegistryEntry, error) {
 	if err != nil {
 		return nil, err
 	}
-
 	bz, err := io.ReadAll(res.Body)
 	if err != nil {
 		return nil, err
 	}
 
+	if err = res.Body.Close(); err != nil {
+		return nil, err
+	}
+
 	data := &ChainRegistryEntry{}
 	if err = json.Unmarshal(bz, data); err != nil {
 		return nil, err