From 5bbb91676d7f3ef144dfd034c177888184da8b19 Mon Sep 17 00:00:00 2001 From: "mergify[bot]" <37929162+mergify[bot]@users.noreply.github.com> Date: Sat, 28 Dec 2024 22:41:04 +0100 Subject: [PATCH] docs: Quotation marks are used incorrectly. (backport #23071) (#23114) Co-authored-by: leo --- docs/architecture/adr-031-msg-service.md | 2 +- docs/architecture/adr-033-protobuf-inter-module-comm.md | 2 +- docs/architecture/adr-036-arbitrary-signature.md | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/architecture/adr-031-msg-service.md b/docs/architecture/adr-031-msg-service.md index 8185509bd190..772bd8b1ee93 100644 --- a/docs/architecture/adr-031-msg-service.md +++ b/docs/architecture/adr-031-msg-service.md @@ -26,7 +26,7 @@ that `Msg` return types be captured using a protobuf extension field, ex: package cosmos.gov; message MsgSubmitProposal - option (cosmos_proto.msg_return) = “uint64”; + option (cosmos_proto.msg_return) = "uint64"; string delegator_address = 1; string validator_address = 2; repeated sdk.Coin amount = 3; diff --git a/docs/architecture/adr-033-protobuf-inter-module-comm.md b/docs/architecture/adr-033-protobuf-inter-module-comm.md index 83bb4dcb242f..b3fab3d9cbb0 100644 --- a/docs/architecture/adr-033-protobuf-inter-module-comm.md +++ b/docs/architecture/adr-033-protobuf-inter-module-comm.md @@ -43,7 +43,7 @@ own account. These permissions are actually stored as a `[]string` array on the However, these permissions don’t really do much. They control what modules can be referenced in the `MintCoins`, `BurnCoins` and `DelegateCoins***` methods, but for one there is no unique object capability token that controls access — just a simple string. So the `x/upgrade` module could mint tokens for the `x/staking` module simple by calling -`MintCoins(“staking”)`. Furthermore, all modules which have access to these keeper methods, also have access to +`MintCoins("staking")`. Furthermore, all modules which have access to these keeper methods, also have access to `SetBalance` negating any other attempt at OCAPs and breaking even basic object-oriented encapsulation. ## Decision diff --git a/docs/architecture/adr-036-arbitrary-signature.md b/docs/architecture/adr-036-arbitrary-signature.md index fe9dada54164..f2d442be4d38 100644 --- a/docs/architecture/adr-036-arbitrary-signature.md +++ b/docs/architecture/adr-036-arbitrary-signature.md @@ -33,7 +33,7 @@ The aim is being able to sign arbitrary messages, even using Ledger or similar H As a result signed messages should look roughly like Cosmos SDK messages but **must not** be a valid on-chain transaction. `chain-id`, `account_number` and `sequence` can all be assigned invalid values. -Cosmos SDK 0.40 also introduces a concept of “auth_info” this can specify SIGN_MODES. +Cosmos SDK 0.40 also introduces a concept of "auth_info" this can specify SIGN_MODES. A spec should include an `auth_info` that supports SIGN_MODE_DIRECT and SIGN_MODE_LEGACY_AMINO. @@ -43,7 +43,7 @@ An offchain transaction follows these rules: * the memo must be empty * nonce, sequence number must be equal to 0 -* chain-id must be equal to “” +* chain-id must be equal to "" * fee gas must be equal to 0 * fee amount must be an empty array