all: for Go deprecation notices, please use "Deprecated:" not "DEPRECATED"

[odeke-em]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

While reviewing #17657 I noticed the use of "DEPRECATED" and search for similar content in the cosmos-sdk shows these hits

$ git grep 'DEPRECATED'
api/cosmos/tx/v1beta1/service.pulsar.go:        // DEPRECATED: use BROADCAST_MODE_SYNC instead,
client/docs/swagger-ui/swagger.yaml:                   - BROADCAST_MODE_BLOCK: DEPRECATED: use BROADCAST_MODE_SYNC instead,
client/docs/swagger-ui/swagger.yaml:       - BROADCAST_MODE_BLOCK: DEPRECATED: use BROADCAST_MODE_SYNC instead,
client/docs/swagger-ui/swagger.yaml:           - BROADCAST_MODE_BLOCK: DEPRECATED: use BROADCAST_MODE_SYNC instead,
client/v2/autocli/testdata/help-echo-msg.golden:      --deprecated-field string                                               (DEPRECATED: don't use this)
client/v2/autocli/testdata/help-echo-msg.golden:  -d, --shorthand-deprecated-field string                                     (DEPRECATED: bad idea)
client/v2/autocli/testdata/help-echo.golden:      --deprecated-field string                                               (DEPRECATED: don't use this)
client/v2/autocli/testdata/help-echo.golden:  -s, --shorthand-deprecated-field string                                     (DEPRECATED: bad idea)
client/v2/autocli/testdata/help.golden:      --deprecated-field string                                               (DEPRECATED: don't use this)
client/v2/autocli/testdata/help.golden:  -s, --shorthand-deprecated-field string                                     (DEPRECATED: bad idea)
proto/cosmos/base/tendermint/v1beta1/query.proto:  // DEPRECATED: use "value" instead
proto/cosmos/tx/v1beta1/service.proto:  // DEPRECATED: use BROADCAST_MODE_SYNC instead,
simapp/params/amino.go:// [DEPRECATED]
simapp/params/proto.go:// [DEPRECATED]
Binary file store/streaming/abci/examples/stdout/stdout matches
types/tx/service.pb.go: // DEPRECATED: use BROADCAST_MODE_SYNC instead,

We should be following https://rakyll.org/deprecated/ which allows Go tools like IDEs to flag usages of deprecated APIs.

Cosmos SDK Version

167b702

How to reproduce?

No response

[JulianToledano]

There are some with the format Deprecated post...

api/cosmos/tx/v1beta1/service.pulsar.go:        // Deprecated post v0.47.x: use query instead, which should contain a valid
api/cosmos/tx/v1beta1/service.pulsar.go:        // Deprecated post v0.46.x: use page and limit instead.
api/cosmos/tx/v1beta1/service.pulsar.go:        // Deprecated post v0.46.x: use total instead.
client/docs/swagger-ui/swagger.yaml:            Deprecated post v0.47.x: use query instead, which should contain a
client/docs/swagger-ui/swagger.yaml:          Deprecated post v0.46.x: use total instead.
proto/cosmos/tx/v1beta1/service.proto:  // Deprecated post v0.47.x: use query instead, which should contain a valid
proto/cosmos/tx/v1beta1/service.proto:  // Deprecated post v0.46.x: use page and limit instead.
proto/cosmos/tx/v1beta1/service.proto:  // Deprecated post v0.46.x: use total instead.
types/tx/service.pb.go: // Deprecated post v0.47.x: use query instead, which should contain a valid
types/tx/service.pb.go: // Deprecated post v0.46.x: use page and limit instead.
types/tx/service.pb.go: // Deprecated post v0.46.x: use total instead.

[odeke-em]

Thanks for the additional reports @JulianToledano!