[audit]: client/keys: Test_runImportHexCmd could become flaky due to overzealous os.Removeall(t.TempDir()) instead of creating a fresh directory of its own

[odeke-em]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

Noticed in an audit that Test_runImportHexCmd added this code in v0.50.0-rc.0

+                       // Now add a temporary keybase
+                       kbHome := t.TempDir()
+                       kb, err := keyring.New(sdk.KeyringServiceName(), tc.keyringBackend, kbHome, nil, cdc)
+                       require.NoError(t, err)
+
+                       clientCtx := client.Context{}.
+                               WithKeyringDir(kbHome).
+                               WithKeyring(kb).
+                               WithInput(mockIn).
+                               WithCodec(cdc)
+                       ctx := context.WithValue(context.Background(), client.ClientContextKey, &clientCtx)
+
+                       t.Cleanup(cleanupKeys(t, kb, "keyname1"))
+
+                       defer func() {
+                               _ = os.RemoveAll(kbHome)
+                       }()

but a few problems:

• (*testing.T).TempDir() is meant to be controlled by the framework itself
• invoking kbHome := t.TempDir() should be fixed up to kbHome := filepath.Join(t.TempDir(), fmt.Sprintf("%x", tc.name)))
• invoking defer func() { _ = os.RemoveAll(kbHome) }() deletes t.TempDir() but it should have gotten a fresh directory

We need to fix the above, otherwise the behavior will be undefined and it is trivial to fix compared to the problems that'll be caused.

Cosmos SDK Version

v0.50.0-rc.0

How to reproduce?

No response

[JulianToledano]

@odeke-em should we do the same with:

cosmos-sdk/client/keys/import_test.go

Lines 82 to 84 in 35d93a9

	// Now add a temporary keybase
	kbHome := t.TempDir()
	kb, err := keyring.New(sdk.KeyringServiceName(), tc.keyringBackend, kbHome, nil, cdc)

[odeke-em]

Yes please @JulianToledano!