[Bug]: Module not Registered but still used on client

[cloud-j-luna]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

I want to be able to pass the modules to register in my client. So that I can at runtime decide whether it will be a cosmos client or other chain.

I have the following variable:

var AkashModuleBasics = []module.AppModuleBasic{
	agov.AppModuleBasic{}, // This comes from Akash's governance module.
}

And this method that adds the modules together:

func NewBasicManager(modules ...[]module.AppModuleBasic) module.BasicManager {
	all := []module.AppModuleBasic{
		// accounts, fees.
		auth.AppModuleBasic{},
		// tokens, token balance.
		bank.AppModuleBasic{},
	}

	for _, appModule := range modules {
		all = append(all, appModule...)
	}

	return module.NewBasicManager(all...)
}

encodingConfig := MakeEncodingConfig()

std.RegisterLegacyAminoCodec(encodingConfig.Amino)
std.RegisterInterfaces(encodingConfig.InterfaceRegistry)
NewBasicManager(AkashModuleBasics).RegisterLegacyAminoCodec(encodingConfig.Amino)
NewBasicManager(AkashModuleBasics).RegisterInterfaces(encodingConfig.InterfaceRegistry)

This works if I try to send tokens between Akash addresses.
If I pass an empty []module.AppModuleBasic{} like this:

encodingConfig := MakeEncodingConfig()

std.RegisterLegacyAminoCodec(encodingConfig.Amino)
std.RegisterInterfaces(encodingConfig.InterfaceRegistry)
NewBasicManager([]module.AppModuleBasic{}).RegisterLegacyAminoCodec(encodingConfig.Amino)
NewBasicManager([]module.AppModuleBasic{}).RegisterInterfaces(encodingConfig.InterfaceRegistry)

I get the error invalid Bech32 prefix; expected akash, got cosmos which is weird, since I did not include any reference to AkashModuleBasics.

Now, if I remove all the modules from inside the AkashModuleBasics so that the slice is empty, the code works.
It leads me to believe that there is some kind of reflection in use that finds my AkashModuleBasics even if I do not specifically register it.

Cosmos SDK Version

v0.45.16

How to reproduce?

No response

[julienrbrt]

Where exactly do you get this error?
There is no reflection in the basic manager.

[cloud-j-luna]

On this line addr, err := sdk.AccAddressFromBech32(source).

[troian]

cosmos-sdk config is a singleton, whenever akash module included it will call for this and seal the config which includes bech type

[cloud-j-luna]

cosmos-sdk config is a singleton, whenever akash module included it will call for this and seal the config which includes bech type

@julienrbrt Any chance this can be discussed? This limits SDK applications to manage different chains, or is there a known workaround?

[julienrbrt]

cosmos-sdk config is a singleton, whenever akash module included it will call for this and seal the config which includes bech type

@julienrbrt Any chance this can be discussed? This limits SDK applications to manage different chains, or is there a known workaround?

That's not due to the SDK. Apparently importing Akash modules has side effects (that init function will be called). There is nothing the SDK can do about it.

[troian]

Yeah, it's kind of wanky solution from our side, coming from the fact the sdk.GetConfig which returns singleton is still in use within cosmos-sdk. We had a few cases when config instantiation was missing from API standpoint and decided to put that in init so it get's initialized every time akash SDK is included.