x/simulation: the liveness matrix no longer affects simulation

[elias-orijtech]

The code that determines whether a simulated validator signs a block,

cosmos-sdk/x/simulation/mock_cometbft.go

Lines 140 to 170 in 337b3fe

	mVal.livenessState = params.LivenessTransitionMatrix().NextState(r, mVal.livenessState)
	signed := true
	if mVal.livenessState == 1 {
	// spotty connection, 50% probability of success
	// See https://github.com/golang/go/issues/23804#issuecomment-365370418
	// for reasoning behind computing like this
	signed = r.Int63()%2 == 0
	} else if mVal.livenessState == 2 {
	// offline
	signed = false
	}
	if signed {
	event("begin_block", "signing", "signed")
	} else {
	event("begin_block", "signing", "missed")
	}
	pubkey, err := cryptoenc.PubKeyFromProto(mVal.val.PubKey)
	if err != nil {
	panic(err)
	}
	voteInfos[i] = abci.VoteInfo{
	Validator: abci.Validator{
	Address: pubkey.Address(),
	Power: mVal.val.Power,
	},
	BlockIdFlag: cmtproto.BlockIDFlagCommit,
	}

no longer has any effect on the simulation, but merely collects statistics through the event function pointer.

As pointed out by @alexanderbez, v0.47 does propagate the signing parameter to the simulation:

cosmos-sdk/x/simulation/mock_tendermint.go

Line 161 in 9acdbb9

SignedLastBlock: signed,

This change was made as part of the Comet v0.38 integration, 6cee22d.

[elias-orijtech]

Note that this issue is for posterity; it can be closed once the simulator is replaced.

[tac0turtle]

is this solved @alpe

[alpe]

No, the liveness metric is not taken into account. All validators "sign" currently