[Bug]: feegrant relies on cosmossdk.io/core v0.12.0 but sdk-rc.1 relies on cosmossdk.io/core v0.11.0

[jtieri]

Is there an existing issue for this?

• I have searched the existing issues

What happened?

I'm currently working on upgrading the go-relayer to sdk v0.50.0-rc.1 and noticed that after accounting for all breaking changes and trying to compile I get the following errors:

# github.com/cosmos/cosmos-sdk/types
../../../../pkg/mod/github.com/cosmos/[email protected]/types/context.go:64:29: undefined: comet.BlockInfo
../../../../pkg/mod/github.com/cosmos/[email protected]/types/context.go:91:36: undefined: comet.BlockInfo
../../../../pkg/mod/github.com/cosmos/[email protected]/types/context.go:299:48: undefined: comet.BlockInfo
make: *** [install] Error 1

I saw in my indirect dependencies that cosmossdk.io/core v0.12.0 is being imported but the latest rc of sdk v0.50.0 relies on cosmossdk.io/core v0.11.0. After doing some digging I realized that v0.12.0 is imported because the go-relayer also imports cosmossdk.io/x/feegrant.

comet.BlockInfo was renamed to comet.Info from v0.11.0 -> v0.12.0 so the Go module system complains because when two deps with the same major revision are needed it defaults to the most recent version.

I was curious if there were plans to upgrade this dependency in sdk 0.50.0 in the next release candidate?

Additionally I was wondering if there were plans to create tags for the feegrant module because right now it's one of the modules that are its own Go module but there are not explicit tags being created for it so you have to rely on a commit sha

Cosmos SDK Version

0.50.0-rc.1

How to reproduce?

Import cosmos sdk v0.50.0-rc.1 along with the latest commit sha from the feegrant module then try to compile the code that is importing both dependencies.

[julienrbrt]

It will be clearer once we tag the modules, but you need to take the latest commit of the release branch.
x/feegrant on the release/v0.50.x imports the correct version of core that is compatible with v0.50 (https://github.com/cosmos/cosmos-sdk/blob/release/v0.50.x/x/feegrant/go.mod#L7).

All modules that import the SDK are tagged from release branches (see https://github.com/cosmos/cosmos-sdk/blob/main/RELEASE_PROCESS.md#cosmos-sdk-modules)