Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Different behavior amino_dont_omitempty x/tx #22862

Open
1 task done
julienrbrt opened this issue Dec 13, 2024 · 0 comments
Open
1 task done

[Bug]: Different behavior amino_dont_omitempty x/tx #22862

julienrbrt opened this issue Dec 13, 2024 · 0 comments
Assignees
Labels

Comments

@julienrbrt
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

What happened?

With the bump of api in v0.52, we can see that x/tx doesn't respect the amino.dont_omitempty annotation.

For context, on main a metadata message has been added in the validator description.
It was then made nullable so that API (tagged from main) stays compatible with 0.52: #22556.
That fixed the marshal issue: https://github.com/cosmos/cosmos-sdk/actions/runs/11914721341/job/33203345359.
However x/tx has a different behavior then legacy amino when marshalling:

ref: https://github.com/cosmos/cosmos-sdk/actions/runs/12312258775/job/34363954928
Image

Cosmos SDK Version

x/tx v1.0.0-alpha.3

How to reproduce?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants