Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add x/upgrade gRPC query for module VersionMap #8941

Closed
4 tasks
amaury1093 opened this issue Mar 19, 2021 · 2 comments · Fixed by #9073
Closed
4 tasks

Add x/upgrade gRPC query for module VersionMap #8941

amaury1093 opened this issue Mar 19, 2021 · 2 comments · Fixed by #9073
Assignees
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. C:x/upgrade

Comments

@amaury1093
Copy link
Contributor

Summary

Add x/upgrade gRPC query for module VersionMap

ref: ADR-041 and #8743 (review)

Problem Definition

There's no way to query the current module.VersionMap stored in x/upgrade state.

Proposal

Add a gRPC method in the x/upgrade Query service.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@amaury1093 amaury1093 added C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. C:x/upgrade labels Mar 19, 2021
@technicallyty
Copy link
Contributor

Should it be as simple as querying for the entire version map, or should we add methods to ask for a specific module / set of modules?

@amaury1093
Copy link
Contributor Author

Maybe the request message could have one module string field, if it's set then query the version of that module, if not, then query whole map. Is this a common/intuitive practise? wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: gRPC Issues and PRs related to the gRPC service and HTTP gateway. C:x/upgrade
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants