chore!: improve lsm err handling and testing #22519

MSalopek · 2024-11-13T13:41:27Z

Description

Changes only affect the LSM feature branches and tags.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

included the correct type prefix in the PR title, you can find examples of the prefixes below:
confirmed ! in the type prefix if API or client breaking change
targeted the correct branch (see PR Targeting)
provided a link to the relevant issue or specification
reviewed "Files changed" and left comments if necessary
included the necessary unit and integration tests
added a changelog entry to CHANGELOG.md
updated the relevant documentation or specification, including comments for documenting Go code
confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

confirmed the correct type prefix in the PR title
confirmed all author checklist items have been addressed
reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

coderabbitai · 2024-11-13T13:41:40Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

mpoke

LGTM

mpoke · 2024-11-13T13:53:50Z

x/staking/client/cli/tx.go

 		Args:  cobra.ExactArgs(1),
 		Long: strings.TrimSpace(
-			fmt.Sprintf(`Mark a delegation as a validator self-bond.
+			fmt.Sprintf(`Mark a delegation as a validator bond. This can be done by any delegator but it is recommended to be done from the validator's delegation address.


Why the recommendation?

x/staking/keeper/liquid_stake.go

-	store.Set(types.TotalLiquidStakedTokensKey, tokensBz)
+	err = store.Set(types.TotalLiquidStakedTokensKey, tokensBz)
+	if err != nil {
+		panic(err)


x/staking/keeper/liquid_stake.go

-	store.Delete(key)
+	err := store.Delete(key)
+	if err != nil {
+		panic(err)


x/staking/keeper/liquid_stake.go

-		store.Delete(k)
+		err := store.Delete(k)
+		if err != nil {
+			panic(err)


MSalopek added 4 commits November 11, 2024 13:50

fix!: validate shares amount during TokenizeShare

2385e93

nits: add more err checks for store operations

a303122

fix: increase vbs for vbd

2436420

chore: add lsm testing & docs

a0fd446

MSalopek requested a review from a team as a code owner November 13, 2024 13:41

github-actions bot added C:x/staking C:CLI labels Nov 13, 2024

mpoke approved these changes Nov 13, 2024

View reviewed changes

github-advanced-security bot found potential problems Nov 13, 2024

View reviewed changes

MSalopek mentioned this pull request Nov 15, 2024

chore!: lsm redelegation follow-up #22538

Merged

12 tasks

mpoke merged commit 3df8f2e into cosmos:feature/v0.50.x-lsm Nov 18, 2024
61 of 63 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore!: improve lsm err handling and testing #22519

chore!: improve lsm err handling and testing #22519

MSalopek commented Nov 13, 2024 •

edited

Loading

coderabbitai bot commented Nov 13, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

mpoke left a comment

mpoke Nov 13, 2024

chore!: improve lsm err handling and testing #22519

chore!: improve lsm err handling and testing #22519

Conversation

MSalopek commented Nov 13, 2024 • edited Loading

Description

Author Checklist

Reviewers Checklist

coderabbitai bot commented Nov 13, 2024

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

mpoke left a comment

Choose a reason for hiding this comment

mpoke Nov 13, 2024

Choose a reason for hiding this comment

MSalopek commented Nov 13, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)