Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add post-order export & restoring #853

Merged
merged 4 commits into from
Nov 27, 2023
Merged

feat: add post-order export & restoring #853

merged 4 commits into from
Nov 27, 2023
+310 −112

Conversation

cool-develope
Copy link
Collaborator

ref: #852

@cool-develope cool-develope requested a review from a team as a code owner November 16, 2023 14:24
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Nov 16, 2023

Important

Auto Review Skipped

Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

yihuang
yihuang reviewed Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good to me, but I think we need to add some tests for it.

tree_test.go
@@ -205,13 +204,14 @@ func TestTree_Build_Load(t *testing.T) {

// export the tree at version 12,000 and import it into a sql db
ctx := context.Background()
traverseOrder := PreOrder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test for post-order traversal.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, let's have this test run for both pre and post order.

kocubinski
kocubinski reviewed Nov 21, 2023
View reviewed changes
snapshot.go Outdated
return node, uniqueVersions, err
}

func (snap *sqliteSnapshot) writeSnapNode(node *Node, version int64, count int) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the write logic may need to change a bit here now, if you pull v2-alpha6 you'll see what I mean. I needed to incorporate an additional flag to accommodate multiple write paths in snapshot.

https://github.com/cosmos/iavl/blob/640a21ec34b532d04886b6de2085c809dca6f343/snapshot.go#L30C1-L31

@cool-develope cool-develope merged commit 4330ebc into v2-alpha6 Nov 27, 2023
2 of 5 checks passed
@cool-develope cool-develope deleted the feat/post_order branch November 27, 2023 16:16
@cool-develope cool-develope mentioned this pull request Dec 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang left review comments

@kocubinski kocubinski kocubinski approved these changes

Assignees

@yihuang yihuang

@kocubinski kocubinski

@alexanderbez alexanderbez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cool-develope @yihuang @kocubinski @alexanderbez