Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backporting raft_register_state_cb and making compatible with canonical/raft v0.18.1 #178

Open
listout opened this issue Feb 20, 2024 · 3 comments

Comments

@listout
Copy link

listout commented Feb 20, 2024

canonical/raft@6535161 adds a callback function raft_register_state_cb. In gentoo we ship dqlite which is dependent on cowsql/raft and it's failing with build error

rc/server.c: error: implicit declaration of function raft_register_state_cb

Refer: https://bugs.gentoo.org/925012

@freeekanayaka
Copy link
Member

freeekanayaka commented Feb 20, 2024

TL;DR: starting from the next dqlite release this won't a be a problem anymore since the whole canonical/raftsource code will be moved directly inside the canonical/dqlite repository, and built together in a single shared library.

See this comment canonical/dqlite#549 (comment) and this PR canonical/dqlite#568.

Note that dqlite 1.16.0 works fine with canonical/cowsql. The only non-compatible release is dqlite 1.16.2. Would it be fine for you/gentoo to just to wait for dqlite 1.16.3 and stick with 1.16.0 fow now? It doesn't make much sense to fix this issue which is effectively going away soon.

@juippis
Copy link

juippis commented Feb 20, 2024

That sounds good, will do that.

gentoo-bot pushed a commit to gentoo/gentoo that referenced this issue Feb 20, 2024
This reverts commit d8e93a6.

Upstream issue with rationale:
 cowsql/raft#178

Bug: https://bugs.gentoo.org/925012
Signed-off-by: Joonas Niilola <[email protected]>
@freeekanayaka
Copy link
Member

That sounds good, will do that.

https://github.com/canonical/dqlite/releases/tag/v1.16.3

you can now build dqlite with --enable-build-raft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants