-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A minimal std::expected<T, E> #12
Open
deanberris
wants to merge
6
commits into
cpp-netlib:main
Choose a base branch
from
deanberris:topic/simple-connection
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change includes a minimal implementation of the std::expected<T, E> proposal in P0323R3 (http://wg21.link/P0323R3) which is hosted in the `cppnetlib` repository. In the process we also document some of our guidelines on the structure of the repository, on naming files, directory structure, and dependency requirements. Still TODO: * Fill out the test suite. * Update documentation on using vcpkg on dependencies. * Work our way up to a minimal interface for a connecton type, using our std::expected utility type. This is related to the work in netlib/cpp-netlib#5 for implementing a minimal connection type suitable as a building block for higher level protocol implementations.
deanberris
changed the title
Work In Progress: A minimal std::expected<T, E>
A minimal std::expected<T, E>
Feb 15, 2019
Hi @glynos -- this is now ready for a look. Some thoughts:
|
Suggests to separate test code into another directory lead to more clean layout. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes a minimal implementation of the std::expected<T, E>
proposal in P0323R3 (http://wg21.link/P0323R3) which is hosted in the
cppnetlib
namespace.In the process we also document some of our guidelines on the structure
of the repository, on naming files, directory structure, and dependency
requirements.
Still TODO:
std::expected utility type.
This is related to the work in #5 for implementing a minimal
connection type suitable as a building block for higher level protocol
implementations.