Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

サンプルコード検出の古い判別処理が残っているため一部のページでコード実行機能が表示されない #71

Closed
saki7 opened this issue Dec 5, 2017 · 2 comments
Labels

Comments

@saki7
Copy link
Contributor

saki7 commented Dec 5, 2017

これを丸ごと消す

kunai/js/kunai.js

Lines 90 to 96 in ede7b2f

// whitelist
{
let example = this.meta.getDOM(Meta.PageKey.articleBody).children('h2:contains("例") ~ .yata')
if (example.length) {
example.removeClass('hidden')
}
}

これも消す

elem.addClass('hidden') // hide by default

この2か所を消せば動くようになると思う、ツールバーは生成されてて非表示になってるだけなので。自分は今すぐに対応できる状況にないので、PRを投げて頂ければマージはします

@saki7
Copy link
Contributor Author

saki7 commented Dec 5, 2017

ref: #69 これに影響

@saki7
Copy link
Contributor Author

saki7 commented Dec 5, 2017

cpprefjp/site#488 ←これで直らなかったやつはこのIssueが影響してる

@saki7 saki7 closed this as completed in 6b6226f Dec 13, 2017
saki7 added a commit that referenced this issue Dec 13, 2017
Patch code detection logic, remove old logic; fixes #71
@saki7 saki7 removed the help wanted label Dec 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant