Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It would be great if you guys start developing a version for angular 4x #11

Open
sairam0903 opened this issue Apr 12, 2017 · 12 comments
Open

Comments

@sairam0903
Copy link

No description provided.

@thanhdevapp
Copy link

one vote, pls

@developerslearnit
Copy link

It will be very great

@craftpip
Copy link
Owner

craftpip commented May 4, 2017

thanks for the support,
i will be starting on it shortly 👍

@akurutin
Copy link

one vote, pls

@craftpip
Copy link
Owner

What should i name it ? angular2-confirm ? angular4-confirm ?
suggestions please

@akurutin
Copy link

Depends on compatibility
If with both(2 and 4) - angular 2; else angular 4

@smasherprog
Copy link

angular 2-4 is now known as just angular

angular1 is referred to as angularjs

so this library should be called angularjs-confirm

the angular2 and up should be called angular-confirm

The above follows the angular naming conventions

Another option alot of people use is the prefix of ng2
ng2-confirm would work as well, but would be different then your current naming.

In any case, I would love an angular version of this! angular4 that is

@albertoVieiraNeto
Copy link

+1

@vanditamathur
Copy link

vanditamathur commented Jun 27, 2017

Looking forward to the Angular 4 version of this. What is the expected timeline?

@craftpip
Copy link
Owner

I need suggestions from you guys on this,

Idea:
Originally my goal was to implement this plugin in such a way that you can render Components in side of the modal.

Problem:
Angular has been changing its Api's rapidly for dynamic component loading. Which has changed a lot since angular2 final was released, i.e. Component loading is different in angular 2 and 4.
Developing an angular version of this plugin and making it stable will take more time.

Solution:
My suggestion is that have a angular service for the original jquery-confirm project, which will bring jquery as an dependency, but will give this project a longer life and keep it stable with all angular versions, Is it okay?

Please let me know what you think.

@vanditamathur
Copy link

jquery as a dependency should be fine.

@kolte
Copy link

kolte commented Oct 16, 2017

I just love this plugin, it's the simplest and the best I have ever used.
Re. Angular 2/4
It is very much stable now, no drastic changes that can break the plugin entirely. have you created this plugin for angular 2/4 already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants