Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow interactive usage with prompt to confirm that changes are written #397

Open
ninsbl opened this issue Jan 5, 2022 · 3 comments · May be fixed by #1119
Open

Allow interactive usage with prompt to confirm that changes are written #397

ninsbl opened this issue Jan 5, 2022 · 3 comments · May be fixed by #1119
Labels
enhancement Improve the expected

Comments

@ninsbl
Copy link

ninsbl commented Jan 5, 2022

When spellchecking a lager project with lots of history and contributions from all over the world for the first time, I would like to confirm each change before it is written and eventually collect cases to be added to exceptions from automatic spell correction.

Therefore, an interactive flag, that adds a prompt before changes are written would be very useful for initial spell checking.
@epage epage added the enhancement Improve the expected label Jan 5, 2022
@epage
Copy link
Collaborator

epage commented Jan 5, 2022

Until this is implemented, a project using git can do typos --write-changes && git add -p and use git to interactively stage changes for commit.

@ninsbl
Copy link
Author

ninsbl commented Jan 5, 2022

Cool! Thanks for the swift reply and for the suggestion on the workaround! I did not know and will try!

@epage
Copy link
Collaborator

epage commented Jan 5, 2022

Implementation note: while an MVS will just be conditional modifying, it'd be great if we later supported asking the user if they want to put a term in the approved-words list. We can use toml_edit to non-destructively edit the file.

@ninsbl ninsbl mentioned this issue Jan 8, 2022
Merged
@epage epage mentioned this issue Mar 31, 2023
Closed
@epage epage mentioned this issue May 9, 2024
Closed
@Bnyro Bnyro linked a pull request Oct 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improve the expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add --interactive option to prompt for each change Bnyro/typos
2 participants
@epage @ninsbl