Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add clarification in Development documentation about running E2E Tests #5

Open
1 task
rohanKanojia opened this issue Nov 14, 2024 · 0 comments
Open
1 task
Assignees

Comments

@rohanKanojia
Copy link

rohanKanojia commented Nov 14, 2024

Description

Related to #6

Current CRC Developing documentation isn't clear about how to run E2E tests. It specifies the flags that are supposed to be passed but doesn't specify the correct way of passing them.

Currently this is how E2E tests are prescribed to be run :

make e2e GODOG_OPTS="--godog.tags='@basic && @windows'" BUNDLE_LOCATION=<bundle location> PULL_SECRET_FILE=<pull secret path>

However, when I was trying to provide values in those variables, tests were not picking right bundle and pull secret file.

When I ran them by providing flags as well, it worked (notice how flags are specified again in cli form --bundle-location= inside env variable):

make e2e GODOG_OPTS="--godog.tags='@basic'" BUNDLE_LOCATION="--bundle-location=/home/rokumar/.crc/cache/crc_libvirt_4.17.0_amd64.crcbundle" PULL_SECRET_FILE="--pull-secret-file=/home/rokumar/Downloads/pull-secret.txt" CRC_BINARY="--crc-binary=/home/rokumar/go/bin/crc"

Expected Behavior

Development docs clearly describe how to run E2E tests.

Acceptance Criteria

  • Clarification is provided about how to property override default values used by tests, and what is proper way to override those.
@gbraad gbraad self-assigned this Nov 14, 2024
@gbraad gbraad transferred this issue from crc-org/crc Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

2 participants