Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify imageformat according to file used #11

Open
Tracked by #1341
, #211
...
gbraad opened this issue Jul 15, 2020 · 1 comment
Open
Tracked by #1341
, #211
...

Modify imageformat according to file used #11

gbraad opened this issue Jul 15, 2020 · 1 comment

Comments

@gbraad
Copy link

gbraad commented Jul 15, 2020

https://github.com/code-ready/machine-driver-hyperkit/blob/c592b26d73624e85e1bdb7d962c6f0cea99740e1/pkg/hyperkit/driver.go#L228-L234

When raw imageformat is to be used, the driver needs to handle either a single format or infer this from the file referenced. Related to crc-org/snc#206
@gbraad gbraad mentioned this issue Jul 15, 2020
Open
1 task
@guillaumerose guillaumerose mentioned this issue Jul 15, 2020
Open
2 tasks
@cfergeau
Copy link

crc-org/machine#39 adds a VMDriver.ImageFormat field which would make this easier to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gbraad @cfergeau