Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit how crc/this helper starts background processes? #5

Open
cfergeau opened this issue Jul 1, 2024 · 0 comments
Open

Revisit how crc/this helper starts background processes? #5

cfergeau opened this issue Jul 1, 2024 · 0 comments

Comments

@cfergeau
Copy link
Collaborator

cfergeau commented Jul 1, 2024

win32-background-helper triggers warnings from malware detectors, as what it's doing is probably similar to what some malware are doing.
We could revisit how processes are started in the background.
One approach could be to use https://github.com/apenwarr/fixconsole/blob/5a9f6489cc2959fbd7474e4429d33b32f096c9bd/fixconsole_windows.go#L30-L75 so that we can start unmodified binaries in the background without briefly showing a black console window

Another approach is to stop using a background windows task and a special process to start in the background, but to start the process we need on demand, and make use of https://github.com/containers/podman/blob/c3ab75ca459dc52661197c3dd42520bbd3317479/pkg/machine/wsl/wutil/wutil.go#L25-L29
If we go this way, we need to make sure

  • there are no black console window shown when doing it
  • that the process keeps running after crc.exe exits, and after the terminal window it was started from is closed
  • that admin-helper still works (it needs elevated privileges)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant