Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for jQuery 3.1.1. Issue #87 from creativeaura/threesixty-slider #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for jQuery 3.1.1. Issue #87 from creativeaura/threesixty-slider #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 2.0.6 (Nov 17th, 2015)
- Fix for jQuery 3.1.1 [Issue #87](https://github.com/creativeaura/threesixty-slider/issues/87)

## 2.0.5 (Jan 6th, 2015)
- Fixed typo for AppCongif . [Issue #59](https://github.com/creativeaura/threesixty-slider/issues/59)

Expand Down
4 changes: 2 additions & 2 deletions bower.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@
"name": "threesixty-slider",
"description": "360 degree Image Slider",
"main": "dist/threesixty.min.js",
"version": "2.0.5",
"version": "2.0.6",
"ignore": [
".jshintrc",
".editorconfig",
".bowerrc"
],
"dependencies": {},
"devDependencies": {
"jquery": "~1.8.3"
"jquery": "~3.1.1"
Copy link
Contributor

@Igloczek Igloczek Jul 11, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that author is probably not going to update this package, but you don't need to update required version of jQuery, .on('load', callback) will work on any jQuery, but to avoid some very old version, will be great to define that this package works with >=1.8.3

}
}
4 changes: 2 additions & 2 deletions dist/threesixty.min.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "threesixty-slider",
"description": "360 degree Image Slider",
"version": "2.0.5",
"version": "2.0.6",
"repository": {
"type": "git",
"url": "http://github.com/vml-webdev/threesixty-slider.git"
Expand Down
2 changes: 1 addition & 1 deletion src/threesixty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@

base.$el.find(AppConfig.imgList).append(li);

$(image).load(function () {
$(image).on("load", function(){
base.imageLoaded();
});
};
Expand Down
2 changes: 1 addition & 1 deletion tests/default.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
<link rel='stylesheet' href='../node_modules/qunitjs/qunit/qunit.css'>

<!-- add any external libraries your code needs -->
<script src='../bower_components/jquery/jquery.js'></script>
<script src='../bower_components/jquery/dist/jquery.js'></script>

<script src='../src/threesixty.js'></script>
<!-- add any JS files under test (or put them in different .html files) -->
Expand Down