Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a shortcut also deletes the row with the same shortcut key #642

Open
Zankio opened this issue Sep 21, 2024 · 1 comment
Open

Deleting a shortcut also deletes the row with the same shortcut key #642

Zankio opened this issue Sep 21, 2024 · 1 comment

Comments

@Zankio
Copy link

Zankio commented Sep 21, 2024

When deleting the first shortcut, the second one is also deleted.
Eample

  1. Shortcut a for site A
  2. Shortcut a for site B
@Susko3
Copy link

Susko3 commented Nov 15, 2024

Relevant code:

deleteShortcut: function (key) {
this.$buefy.dialog.confirm({
message: 'Delete this shortcut?',
onConfirm: () => this.keys = this.keys.filter(curKey => key.key !== curKey.key)

Should probably be changed to regular reference equality, if that works:

-                onConfirm: () => this.keys = this.keys.filter(curKey => key.key !== curKey.key)
+                onConfirm: () => this.keys = this.keys.filter(curKey => key !== curKey)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants