Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Label Selector does not get propegated to crossplane #21

Open
Avarei opened this issue Jul 10, 2024 · 0 comments · May be fixed by #22
Open

Empty Label Selector does not get propegated to crossplane #21

Avarei opened this issue Jul 10, 2024 · 0 comments · May be fixed by #22
Labels
bug Something isn't working

Comments

@Avarei
Copy link

Avarei commented Jul 10, 2024

What happened?

when setting an empty labelSelector

extraResources:
  - kind: EnvironmentConfig
    into: envConfs
    apiVersion: apiextensions.crossplane.io/v1alpha1
    type: Selector
    selector:
      maxMatch: 2
      minMatch: 1
      matchLabels: []

does not propagete an empty labelSelector to crossplane. instead omitting it altogether.

empty LabelSelectors imply they should match everything.
from api docs:

A selector to restrict the list of returned objects by their labels. Defaults to everything.

How can we reproduce it?

replace

matchLabels:
  - key: type
    type: Value
    value: cluster

with

matchLabels: []

in example/composition.yaml

What environment did it happen in?

Function version: v0.0.3
Crossplane 1.16.0

@Avarei Avarei added the bug Something isn't working label Jul 10, 2024
@Avarei Avarei linked a pull request Jul 10, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant