Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing String transform Type "Join" #119

Closed
haarchri opened this issue May 10, 2024 · 4 comments
Closed

missing String transform Type "Join" #119

haarchri opened this issue May 10, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@haarchri
Copy link
Member

we missing in p&t function String transform Type "Join"
was implemented in crossplane via crossplane/crossplane#5148

@haarchri
Copy link
Member Author

think after implementation we need to update the converter in crossplane cli too

@jbw976 jbw976 added enhancement New feature or request good first issue Good for newcomers labels May 10, 2024
@laseanb
Copy link

laseanb commented May 10, 2024

If this is true - you have saved me a bunch of troubleshooting headache!! I just tried using the "Join" feature but I got the error:

cannot compose resources: pipeline step "patch-and-transform-queue-policy" returned a fatal result: cannot get Function input: cannot get Function input %!T(MISSING) from %!T(MISSING), into, req: cannot unmarshal JSON from *structpb.Struct into *v1beta1.Resources: json: cannot unmarshal Go value of type v1beta1.StringTransform: unknown name "join"

@negz
Copy link
Member

negz commented May 10, 2024

What we really need to do is crossplane/crossplane#4746 to eliminate this entire class of issues. 🙂

@negz negz added the help wanted Extra attention is needed label May 31, 2024
@gschei
Copy link
Contributor

gschei commented Aug 12, 2024

@haarchri this was implemented with #133 and release with v0.7.0, issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants