Allow changing an RDS instance master password, e.g. after restoring from a snapshot

[danports]

This is a follow up from #1087.

What problem are you facing?

As it stands, the provider will never set the master password for instances restored from snapshots: The underlying RestoreDBInstanceFromDBSnapshot AWS API call doesn't support it, and GenerateModifyDBInstanceInput disregards password changes. Thanks to the latter, there's also no way to change the master password for an existing RDS instance if the user desires that.

How could Crossplane help solve your problem?

Provide some mechanism for changing RDS instance master passwords, e.g. by keeping them in sync with the referenced secret.

[eloo]

@danports
i second that request because this would enable us to simply rebind a resource if the kubernetes resource of crossplane was remove with DeletionPolicy: orphan.

i have asked for this scenario in slack already:
https://crossplane.slack.com/archives/C01718T2476/p1643819387848399

[bianchi2]

I wonder if there's any workaround/hack other than calling AWS API directly to reset master credentials

[MisterMX]

Have you checked if #1756 made any differences?

[bianchi2]

Unfortunately, in 0.43.0 it is still an issue

[MisterMX]

As described in #1879 (comment) I think the best way to solve this issue would be to implement something like #1756 for RDSInstance that stores the last password in a cache and performs and update if old and new passwords do not match.

[github-actions]

Crossplane does not currently have enough maintainers to address every issue and pull request. This issue has been automatically marked as stale because it has had no activity in the last 90 days. It will be closed in 14 days if no further activity occurs. Leaving a comment starting with /fresh will mark this issue as not stale.

[Yc-Chen]

I also suffer from the same issue