Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossplane.io/paused on composite doesn't seem to work #1848

Closed
mjnovice opened this issue Aug 23, 2023 · 8 comments
Closed

crossplane.io/paused on composite doesn't seem to work #1848

mjnovice opened this issue Aug 23, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@mjnovice
Copy link

What happened?

How can we reproduce it?

What environment did it happen in?

Crossplane version: crossplane:v1.13.2-up.1

I tried creating a composition of S3 buckets and then annotate it with crossplane.io/paused: "true" and deleted the managed resource on the AWS portal (S3 bucket), and it seemed to get re-created again.

@mjnovice mjnovice added the bug Something isn't working label Aug 23, 2023
@haarchri
Copy link
Member

you need to set this annotation in the individual managed resources - when setting on composition level only the reconcile/update for the managed resource is stopped but not the reconcile to the Cloud Provider API

@mjnovice
Copy link
Author

mjnovice commented Sep 1, 2023

@haarchri I tried that, but it doesn't work.

@MisterMX
Copy link
Collaborator

MisterMX commented Sep 4, 2023

@mjnovice can you provide the YAML of the managed resource to reproduce this bug?

@mjnovice
Copy link
Author

@MisterMX

 ➜  cloudgen-operator git:(mj/gingkgo)  k get securitygroup ci-aseks4428190-g4fwf-qnz4j -oyaml 
apiVersion: ec2.aws.crossplane.io/v1beta1
kind: SecurityGroup
metadata:
  annotations:
    crossplane.io/composition-resource-name: EKS Proxy security group
    crossplane.io/external-create-pending: "2023-09-28T23:47:21Z"
    crossplane.io/external-create-succeeded: "2023-09-28T23:47:22Z"
    crossplane.io/external-name: sg-0f419ad495fb45c52
    crossplane.io/paused: "true"
  creationTimestamp: "2023-09-28T23:47:21Z"
  finalizers:
  - finalizer.managedresource.crossplane.io
  generateName: ci-aseks4428190-g4fwf-
  generation: 2
  labels:
    crossplane.io/claim-name: ci-aseks4428190
    crossplane.io/claim-namespace: sfd-ci-aseks4428190
    crossplane.io/composite: ci-aseks4428190-g4fwf
    crossplane.io/forResource: eks-proxy
    networks.aws.platformref.crossplane.io/refId: ci-aseks4428190
  name: ci-aseks4428190-g4fwf-qnz4j
  ownerReferences:
  - apiVersion: aws.platformref.crossplane.io/v1alpha1
    blockOwnerDeletion: true
    controller: true
    kind: XEKSNetwork
    name: ci-aseks4428190-g4fwf
    uid: 32c389ea-5f86-4d29-be31-c930f74cbfd8
  resourceVersion: "338380346"
  uid: 6d95c85c-4a7c-423e-a1c2-a8e1a2ae4e4d
spec:
  deletionPolicy: Delete
  forProvider:
    description: Proxy securitygroup for EKS worker nodes
    groupName: ci-aseks4428190-eks-proxy-sg
    ignoreEgress: true
    ignoreIngress: true
    region: us-west-2
    tags:
    - key: Name
      value: ci-aseks4428190-eks-proxy-sg
    - key: managedBy
      value: cloudgen-operator
    vpcId: vpc-02e2ea21f7616933a
    vpcIdRef:
      name: ci-aseks4428190-g4fwf-r7hlr
    vpcIdSelector:
      matchControllerRef: true
  providerConfigRef:
    name: service-fabric
status:
  atProvider:
    ownerId: "636035230779"
    securityGroupID: sg-0f419ad495fb45c52
  conditions:
  - lastTransitionTime: "2023-09-28T23:47:24Z"
    reason: Available
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-09-28T23:47:22Z"
    reason: ReconcileSuccess
    status: "True"
    type: Synced

@bobh66
Copy link
Contributor

bobh66 commented Sep 29, 2023

what version of provider-aws are you using?

@mjnovice
Copy link
Author

@bobh66 docker.io/crossplane/provider-aws:v0.32.0

@bobh66
Copy link
Contributor

bobh66 commented Sep 29, 2023

support for the paused annotation starts in v0.33.0 - https://github.com/crossplane-contrib/provider-aws/releases/tag/v0.33.0

@mjnovice
Copy link
Author

mjnovice commented Oct 7, 2023

@bobh66 thanks for the confirmation. This helps. Closing it now

@mjnovice mjnovice closed this as completed Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants