Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump upjet to the commit 3afbb77 #152

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Sep 12, 2024

Description of your changes

This PR bump upjet to the commit 3afbb77, which fixes the issue of hiding error messages.

Fixes #153

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 12, 2024

/test-examples="examples/conditionalaccess/v1beta2/location.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 12, 2024

/test-examples="examples/groups/v1beta1/group.yaml"

@turkenf
Copy link
Collaborator Author

turkenf commented Sep 12, 2024

/test-examples="examples/applications/v1beta2/application.yaml"

Copy link
Collaborator

@mergenci mergenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf. LGTM.

@turkenf turkenf merged commit de40e65 into crossplane-contrib:main Sep 13, 2024
12 checks passed
@turkenf turkenf deleted the bump-upjet-3afbb77 branch September 13, 2024 14:42
Copy link

Successfully created backport PR #154 for release-1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: provider does not report API errors - even in debug logs
2 participants