feat: Upgrade controller-runtime to v0.19.0 #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phisco
reviewed
Aug 21, 2024
| @@ -181,7 +181,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req reconcile.Request) (reco | |||
| if err := r.client.Delete(ctx, pcu); resource.IgnoreNotFound(err) != nil { | |||
| log.Debug(errDeletePCU, "error", err) | |||
| r.record.Event(pc, event.Warning(reasonAccount, errors.Wrap(err, errDeletePCU))) | |||
| return reconcile.Result{RequeueAfter: shortWait}, nil //nolint:nilerr // Returning err would make us requeue instantly. | |||
There was a problem hiding this comment.
looks like golangci-lint still wanted this
There was a problem hiding this comment.
Fixed it. Seems there was a mismatch between the CI and my local linter.
Adjust code to apply to breaking changes in controller-runtime. There should be no breaking changes for programs using crossplane-runtime. Signed-off-by: Maximilian Blatt <[email protected]>
MisterMX
force-pushed
the
feat/controller-runtime-v0.19.0
branch
from
123124e to
3b73e8e
Compare
phisco
reviewed
Sep 3, 2024
| addProviderConfig(evt.Object, q) | ||
| } | ||
|
|
||
| // Generic adds a NamespacedName for the supplied GenericEvent if its Object is | ||
| // a ProviderConfigReferencer. | ||
| func (e *EnqueueRequestForProviderConfig) Generic(_ context.Context, evt event.GenericEvent, q workqueue.RateLimitingInterface) { |
There was a problem hiding this comment.
🤔 Aren't these breaking changes? I guess it's fine though
negz
reviewed
Sep 9, 2024
Comment on lines
+28
to
+32
| // BucketRateLimiter for a standard crossplane reconciler. | ||
| type BucketRateLimiter = workqueue.TypedBucketRateLimiter[string] | ||
|
|
||
| // RateLimiter for a standard crossplane reconciler. | ||
| type RateLimiter = workqueue.TypedRateLimiter[string] |
There was a problem hiding this comment.
Are these type aliases necessary, or just for readability?
I think I like them - just curious.
negz
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This upgrades
sigs.k8s.io/controller-runtimetov0.19.0. Since this library is prone to breaking changes some adjustments are made to apply to some changed interfaces. There should be no breaking changes for programs using only crossplane-runtime.I have:
earthly +reviewableto ensure this PR is ready for review.Linked a PR or a docs tracking issue to document this change.Addedbackport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.