-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for centralized allowlists #3355
base: master
Are you sure you want to change the base?
Conversation
@blotus: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@blotus: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/kind feature |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3355 +/- ##
==========================================
- Coverage 58.44% 54.40% -4.04%
==========================================
Files 351 376 +25
Lines 37818 41947 +4129
==========================================
+ Hits 22101 22821 +720
- Misses 13814 17100 +3286
- Partials 1903 2026 +123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3a34d3a
to
8385b05
Compare
8385b05
to
dbb9adc
Compare
This PR adds a new type of allowlist that is managed by LAPI and applies to alerts, blocklists content and appsec (but not to manual decisions with
cscli
):Compared to existing types of allowlists in crowdsec (in parsers, postoverflows, custom profiles or appsec hooks), they only support IPs and ranges (ie, no arbitrary expression), but they can have an optional expiration.
An alert is considered allowlisted in the following situations:
1.2.3.4
is allowlisted, and an alert on1.2.3.0/24
is generated): while this seems counter-intuitive, range alerts are rare and it would be add a lot of complexity to carve out the specific IPs that are allowlisted from the alert source (and generate multiple sub-alerts).They can be managed with:
cscli
cscli
to avoid conflict), in which case they are pulled from CAPI or PAPI.If a local allowlist is created, and another one with the same name is created in the console, the one from the console will replace the local one.