Skip to content

Commit

Permalink
Get app to build. Switched to pnpm to get this to happen.
Browse files Browse the repository at this point in the history
  • Loading branch information
cloke committed Sep 6, 2024
1 parent d1a41c9 commit 58717a1
Show file tree
Hide file tree
Showing 73 changed files with 572 additions and 17,194 deletions.
40 changes: 30 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,16 +17,36 @@ jobs:
runs-on: ubuntu-latest
timeout-minutes: 10

cache-dependencies:
name: Cache dependencies
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
- name: Install Node.js
uses: actions/setup-node@v4
with:
node-version: 20
cache: "pnpm"
- name: Setup pnpm cache
uses: actions/cache@v4
with:
path: |
node_modules
*/node_modules
key: node_modules-${{runner.os}}-${{hashFiles('**/pnpm-lock.yaml')}}-v2
- name: Install dependencies
run: CI=true pnpm i --frozen-lockfile

build:
name: Build
runs-on: ubuntu-20.04
steps:
- uses: actions/checkout@v3
- name: Install Node
uses: volta-cli/action@v4
- name: Install Dependencies
run: yarn install --frozen-lockfile
- name: Lint
run: yarn lint
run: pnpm lint

- name: Run Tests
run: yarn test:ember
run: pnpm test:ember

floating:
name: "Floating Dependencies"
Expand All @@ -38,9 +58,9 @@ jobs:
- name: Install Node
uses: volta-cli/action@v4
- name: Install Dependencies
run: yarn install --no-lockfile
run: pnpm install --no-lockfile
- name: Run Tests
run: yarn test:ember
run: pnpm test:ember

try-scenarios:
name: ${{ matrix.try-scenario }}
Expand Down Expand Up @@ -73,6 +93,6 @@ jobs:
- name: Install Node
uses: volta-cli/action@v4
- name: Install Dependencies
run: yarn install --frozen-lockfile
run: pnpm install --frozen-lockfile
- name: Run Tests
run: ./node_modules/.bin/ember try:one ${{ matrix.try-scenario }}
27 changes: 6 additions & 21 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,25 +1,10 @@
# compiled output
/dist/
/declarations/
# See https://help.github.com/ignore-files/ for more about ignoring files.

# dependencies
/node_modules/
node_modules/

# misc
/.env*
/.pnp*
/.eslintcache
/coverage/
/npm-debug.log*
/testem.log
/yarn-error.log

# ember-try
/.node_modules.ember-try/
/npm-shrinkwrap.json.ember-try
/package.json.ember-try
/package-lock.json.ember-try
/yarn.lock.ember-try

# broccoli-debug
/DEBUG/
.env*
.pnpm-debug.log
npm-debug.log*
yarn-error.log
39 changes: 0 additions & 39 deletions .npmignore

This file was deleted.

14 changes: 7 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,22 +4,22 @@

* `git clone https://github.com/elwayman02/ember-scroll-modifiers`
* `cd ember-scroll-modifiers`
* `yarn install`
* `pnpm i`

## Linting

- `yarn lint`
- `yarn lint:fix`
- `pnpm lint`
- `pnpm lint:fix`

## Running tests

- `yarn test` – Runs the test suite on the current Ember version
- `yarn test:ember --server` – Runs the test suite in "watch mode"
- `yarn test:ember-compatibility` – Runs the test suite against multiple Ember versions
- `pnpm test` – Runs the test suite on the current Ember version
- `pnpm test:ember --server` – Runs the test suite in "watch mode"
- `pnpm test:ember-compatibility` – Runs the test suite against multiple Ember versions

## Running the dummy application

- `yarn start`
- `pnpm start`
- Visit the dummy application at [http://localhost:4200](http://localhost:4200).

For more information on using ember-cli, visit [https://cli.emberjs.com/release/](https://cli.emberjs.com/release/).
1 change: 0 additions & 1 deletion app/modifiers/did-intersect.js

This file was deleted.

1 change: 0 additions & 1 deletion app/modifiers/scroll-into-view.js

This file was deleted.

3 changes: 0 additions & 3 deletions docs/index.md

This file was deleted.

110 changes: 0 additions & 110 deletions docs/modifiers/did-intersect.md

This file was deleted.

64 changes: 0 additions & 64 deletions docs/modifiers/scroll-into-view.js

This file was deleted.

Loading

0 comments on commit 58717a1

Please sign in to comment.