Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #43

Open
rheitjoh opened this issue Jan 21, 2021 · 0 comments
Open

Improve test coverage #43

rheitjoh opened this issue Jan 21, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@rheitjoh
Copy link
Member

It would be nice to have tests for the following methods (or investigate why there is no test coverage in case IntelliJ is wrong):

  • HashIntoZnAdditiveGroup and HashIntoZp have no coverage at all (although latter should be covered by HashIntoZn)
  • PolynomialRing.Polynomial#scalarProduct(Polynomial)
  • ExtensionField is theoretically covered by the bilinear group tests, but should also be tested in the RingTests
  • None of the new Vector type classes have any test coverage and the other cartesian stuff also doesn't
  • The boolean ring structure has no test coverage
  • RingGroup has no test coverage, but perhaps not necessary here
  • The exception condition for GroupElement#pow(RingElement) is never hit
  • For some reason none of the converter classes have coverage although they are tested in our ConverterTest.
  • Boolean expression stuff has no coverage

For some reason some stuff that is definitely tested has 0% test coverage such as our representation converters, or RingElement#mul(BigInteger), Ring#extendedEuclideanAlgorithm(List<RingElement>).

@rheitjoh rheitjoh added the enhancement New feature or request label Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant