Enable subgroup checks for G1 and G2 via verifyOrder #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
JanBobolz
reviewed
Aug 18, 2021
| @@ -1,5 +1,6 @@ | |||
| #!/usr/bin/env bash | |||
| mcl_version="v1.28" | |||
| #mcl_version="v1.28" | |||
| mcl_version="5faedff92a72a685d4e6c94e1974ec2033b9d352" | |||
There was a problem hiding this comment.
waiting for mcl version v1.52
| @Test | ||
| public void testOnCurve() { | ||
| MclBilinearGroupImpl bilGroupImpl = new MclBilinearGroupImpl(); | ||
| MclGroup2Impl groupG2Impl = bilGroupImpl.getG2(); |
There was a problem hiding this comment.
on curve check works anyway (cannot be disabled) 👍
|
Needs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #28 by adding
verifyOrderG1andverifyOrderG2to the FFI and enabling them after Mcl initialization. This means that subgroup checks are automatically done when using thesetStrmethod which we use for deserialization.Is missing checks for GT since Mcl has no
verifyOrdermethod for that.