New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: missing signer parser for MsgEthereumTx #729

Open

vincentysc opened this issue Aug 9, 2022 · 0 comments

Contributor

vincentysc commented Aug 9, 2022 •

edited

Loading

The Signer of MsgEthereumTx should be the from address. However, a valid MsgEthereumTx should have an empty from address in Tx Messages, possibly deprecated in LegacyTx (Ref: https://github.com/evmos/ethermint/blob/main/x/evm/types/msg.go#L364).

The code shows that ValidateBasic function in Ethermint is not empty and it could be a good starting point (Ref: https://github.com/evmos/ethermint/blob/main/x/evm/types/msg.go#L165).

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment