Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: Missing support of uploading cpp documents to gitbook platform #396

Open
damoncro opened this issue May 11, 2022 · 8 comments
Open

Problem: Missing support of uploading cpp documents to gitbook platform #396

damoncro opened this issue May 11, 2022 · 8 comments

Comments

@damoncro
Copy link
Collaborator

After discussed in gamefi meeting, cpp documents would be uploaded to gitbook platform rather than self-hosted.
@damoncro damoncro mentioned this issue May 11, 2022
Merged
@ricky321q
Copy link

Could we do like having simple explanation at github repo like readme.md , and have full documentation at gitbook>?

@damoncro
Copy link
Collaborator Author

damoncro commented Jun 1, 2022

Is https://github.com/crypto-com/defi-wallet-core-rs/tree/main/docs/cpp enough?

@damoncro
Copy link
Collaborator Author

damoncro commented Jun 1, 2022

Or a direct link to a full doc repo?

@damoncro
Copy link
Collaborator Author

damoncro commented Jun 1, 2022 •
edited
Loading

I can add it into changelogs in 0.2.0 release

@ricky321q
Copy link

Why we should teach the developer with doxygen? I'm talking about the release one Cpp repo to have some simple docs~? Sorry if I misunderstadning?

@damoncro
Copy link
Collaborator Author

damoncro commented Jun 1, 2022 •
edited
Loading

it is internal docs sharing, private doc

@damoncro
Copy link
Collaborator Author

damoncro commented Jun 1, 2022

yup, we will upload the final docs rather than the generation steps in another repo.

damoncro added a commit that referenced this issue Jun 2, 2022
@damoncro
Problem: Missing support of uploading cpp documents to gitbook platfo…
3ef31f7 
…rm (fix #396)

Close:
- #396

Solution:
- Add cronos-play-docs as submodule
- Update Makefile cpp-docs and cpp-cronos-play-docs
@damoncro damoncro mentioned this issue Jun 2, 2022
Closed
@damoncro
Copy link
Collaborator Author

damoncro commented Jun 2, 2022 •
edited
Loading

Add same issue in cronos-labs/play-cpp-sdk#82

@damoncro damoncro closed this as completed Jun 2, 2022
@damoncro damoncro reopened this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@damoncro @ricky321q